Skip to content

Fix error reporting in Windows preset build job #13247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: gh/GregoryComer/110/head
Choose a base branch
from

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Aug 8, 2025

Update the Windows preset build job to accurately report failure. Previously, it was silently failing.

I've updated the script to explicitly check the last exit code. I'm not entirely sure why ErrorActionPreference=Stop isn't doing this. I played around with the escaping a bit and also added PSNativeCommandUseErrorActionPreference = True, but haven't gotten it to fail on exit code. It might be possible to make this work, but I'm just adding an explicit check for now.

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Aug 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13247

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit 5b1330b with merge base 4ce7078 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

GregoryComer added a commit that referenced this pull request Aug 8, 2025
ghstack-source-id: 5ec12b2
ghstack-comment-id: 3169485065
Pull-Request: #13247
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 8, 2025
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 8, 2025
ghstack-source-id: 342cdf8
ghstack-comment-id: 3169485065
Pull-Request: #13247
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 8, 2025
ghstack-source-id: c16c822
ghstack-comment-id: 3169485065
Pull-Request: #13247
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 8, 2025
ghstack-source-id: 8e73876
ghstack-comment-id: 3169485065
Pull-Request: #13247
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 8, 2025
ghstack-source-id: 8d72955
ghstack-comment-id: 3169485065
Pull-Request: #13247
@GregoryComer GregoryComer marked this pull request as ready for review August 9, 2025 00:03
@GregoryComer
Copy link
Member Author

Note that the Windows CI failure is expected, given the current state of the job.

@GregoryComer
Copy link
Member Author

Tracking issue: #12962.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant