Skip to content

Conversation

@mergennachin
Copy link
Contributor

@mergennachin mergennachin commented Aug 15, 2025

Summary:

Trying to resolve #7031

Vibe-coded using the existing non-alias version in ET and Aten implementation in pytorch as reference, along with reference unittests in pytorch core

Test Plan:

  1. Run https://gist.github.com/mergennachin/9b02aee4feb5acc83e71d8f902f5cca1
    And then call ./cmake-out/executor_runner minicpmv_preprocessor.pte

  2. https://gist.github.com/mergennachin/a24e4509804de99caf906c9b79ea45fc

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13458

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 9 Pending, 1 Unrelated Failure

As of commit 0dd4b0e with merge base 2f4b704 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

  • pull / test-binary-size-linux-gcc / linux-job (gh) (trunk failure)
    /pytorch/executorch/kernels/portable/cpu/op_stack.cpp:129:26: error: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘ssize_t’ {aka ‘long int’} [-Werror=sign-compare]

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 15, 2025
@mergennachin mergennachin marked this pull request as draft August 15, 2025 14:06
@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D80343748.

@mergennachin mergennachin force-pushed the fix_upsampling_op branch 2 times, most recently from cd8f804 to c67eace Compare August 15, 2025 14:24
@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D80343748.

@manuelcandales manuelcandales added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Aug 15, 2025
Copy link
Contributor

@manuelcandales manuelcandales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kimishpatel
Copy link
Contributor

along with reference unittests in pytorch core

What does this mean?

@kimishpatel
Copy link
Contributor

along with reference unittests in pytorch core

What does this mean?

nevermind

@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D80343748.

@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D80343748.

@mergennachin mergennachin marked this pull request as ready for review August 15, 2025 15:18
@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D80343748.

@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D80343748.

facebook-github-bot pushed a commit that referenced this pull request Aug 15, 2025
Summary:
Trying to resolve #7031

Vibe-coded using the existing non-alias version in ET and Aten implementation in pytorch as reference, along with reference unittests in pytorch core


Test Plan:
1. Run https://gist.github.com/mergennachin/9b02aee4feb5acc83e71d8f902f5cca1
And then call `./cmake-out/executor_runner minicpmv_preprocessor.pte`

2. https://gist.github.com/mergennachin/a24e4509804de99caf906c9b79ea45fc

Reviewed By: manuelcandales

Differential Revision: D80343748

Pulled By: mergennachin
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80343748

facebook-github-bot pushed a commit that referenced this pull request Aug 15, 2025
Summary:
Trying to resolve #7031

Vibe-coded using the existing non-alias version in ET and Aten implementation in pytorch as reference, along with reference unittests in pytorch core


Test Plan:
1. Run https://gist.github.com/mergennachin/9b02aee4feb5acc83e71d8f902f5cca1
And then call `./cmake-out/executor_runner minicpmv_preprocessor.pte`

2. https://gist.github.com/mergennachin/a24e4509804de99caf906c9b79ea45fc

Reviewed By: manuelcandales

Differential Revision: D80343748

Pulled By: mergennachin
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80343748

mergennachin added a commit that referenced this pull request Aug 15, 2025
Summary:
Trying to resolve #7031

Vibe-coded using the existing non-alias version in ET and Aten implementation in pytorch as reference, along with reference unittests in pytorch core

Test Plan:
1. Run https://gist.github.com/mergennachin/9b02aee4feb5acc83e71d8f902f5cca1
And then call `./cmake-out/executor_runner minicpmv_preprocessor.pte`

2. https://gist.github.com/mergennachin/a24e4509804de99caf906c9b79ea45fc

Reviewed By: manuelcandales

Differential Revision: D80343748

Pulled By: mergennachin
@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D80343748.

mergennachin added a commit that referenced this pull request Aug 16, 2025
Summary:
Trying to resolve #7031

Vibe-coded using the existing non-alias version in ET and Aten implementation in pytorch as reference, along with reference unittests in pytorch core

Test Plan:
1. Run https://gist.github.com/mergennachin/9b02aee4feb5acc83e71d8f902f5cca1
And then call `./cmake-out/executor_runner minicpmv_preprocessor.pte`

2. https://gist.github.com/mergennachin/a24e4509804de99caf906c9b79ea45fc

Reviewed By: manuelcandales

Differential Revision: D80343748

Pulled By: mergennachin
mergennachin added a commit that referenced this pull request Aug 16, 2025
Summary:
Trying to resolve #7031

Vibe-coded using the existing non-alias version in ET and Aten implementation in pytorch as reference, along with reference unittests in pytorch core

Test Plan:
1. Run https://gist.github.com/mergennachin/9b02aee4feb5acc83e71d8f902f5cca1
And then call `./cmake-out/executor_runner minicpmv_preprocessor.pte`

2. https://gist.github.com/mergennachin/a24e4509804de99caf906c9b79ea45fc

Reviewed By: manuelcandales

Differential Revision: D80343748

Pulled By: mergennachin
@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D80343748.

Summary:
Trying to resolve #7031

Vibe-coded using the existing non-alias version in ET and Aten implementation in pytorch as reference, along with reference unittests in pytorch core

Test Plan:
1. Run https://gist.github.com/mergennachin/9b02aee4feb5acc83e71d8f902f5cca1
And then call `./cmake-out/executor_runner minicpmv_preprocessor.pte`

2. https://gist.github.com/mergennachin/a24e4509804de99caf906c9b79ea45fc

Reviewed By: manuelcandales

Differential Revision: D80343748

Pulled By: mergennachin
@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D80343748.

@mergennachin mergennachin merged commit ed61348 into main Aug 16, 2025
103 of 105 checks passed
@mergennachin mergennachin deleted the fix_upsampling_op branch August 16, 2025 17:25
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
Summary:

Trying to resolve pytorch#7031

Vibe-coded using the existing non-alias version in ET and Aten
implementation in pytorch as reference, along with reference unittests
in pytorch core

Test Plan: 

1. Run
https://gist.github.com/mergennachin/9b02aee4feb5acc83e71d8f902f5cca1
And then call `./cmake-out/executor_runner minicpmv_preprocessor.pte`

2. https://gist.github.com/mergennachin/a24e4509804de99caf906c9b79ea45fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: ops & kernels Changes to the opset and any new / changed kernel implementations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kernel 'aten::_upsample_bilinear2d_aa.out' not found.

5 participants