Skip to content

Let's not expose the underlying Method. #13543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Let's not expose the underlying Method. #13543

wants to merge 1 commit into from

Conversation

shoumikhin
Copy link
Contributor

Summary: .

Differential Revision: D80595270

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 20, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13543

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Unrelated Failure

As of commit 5d2c5e2 with merge base 5ae40f1 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 20, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80595270

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Aug 20, 2025
@shoumikhin @facebook-github-bot
Let's not expose the underlying Method. (pytorch#13543)
bdc1390 
Summary:

.

Differential Revision: D80595270
@shoumikhin shoumikhin requested a review from lucylq as a code owner August 20, 2025 06:26
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80595270

shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Aug 22, 2025
@shoumikhin @facebook-github-bot
Let's not expose the underlying Method. (pytorch#13543)
ec0b2f8 
Summary:

.

Reviewed By: mergennachin

Differential Revision: D80595270
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80595270

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80595270

shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Aug 26, 2025
@shoumikhin @facebook-github-bot
Let's not expose the underlying Method. (pytorch#13543)
b037b58 
Summary:
Pull Request resolved: pytorch#13543

.

Reviewed By: JacobSzwejbka, mergennachin

Differential Revision: D80595270
shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Sep 3, 2025
@shoumikhin @facebook-github-bot
Let's not expose the underlying Method. (pytorch#13543)
7a82d05 
Summary:

.

Reviewed By: JacobSzwejbka, mergennachin

Differential Revision: D80595270
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80595270

shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Sep 3, 2025
@shoumikhin @facebook-github-bot
Let's not expose the underlying Method. (pytorch#13543)
4ea77cb 
Summary:
Pull Request resolved: pytorch#13543

.

Reviewed By: JacobSzwejbka, mergennachin

Differential Revision: D80595270
shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Sep 3, 2025
@shoumikhin @facebook-github-bot
Let's not expose the underlying Method. (pytorch#13543)
b1db4b4 
Summary:

.

Reviewed By: JacobSzwejbka, mergennachin

Differential Revision: D80595270
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80595270

JacobSzwejbka
JacobSzwejbka approved these changes Sep 3, 2025
View reviewed changes
Copy link
Contributor

@JacobSzwejbka JacobSzwejbka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Sep 11, 2025
@shoumikhin @facebook-github-bot
Let's not expose the underlying Method. (pytorch#13543)
df8ccd7 
Summary:

.

Reviewed By: JacobSzwejbka, mergennachin

Differential Revision: D80595270
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80595270

shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Sep 11, 2025
@shoumikhin @facebook-github-bot
Let's not expose the underlying Method. (pytorch#13543)
e2c1928 
Summary:
Pull Request resolved: pytorch#13543

.

Reviewed By: JacobSzwejbka, mergennachin

Differential Revision: D80595270
shoumikhin added a commit to shoumikhin/executorch that referenced this pull request Sep 11, 2025
@shoumikhin @facebook-github-bot
Let's not expose the underlying Method. (pytorch#13543)
a829c69 
Summary:

.

Reviewed By: JacobSzwejbka, mergennachin

Differential Revision: D80595270
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80595270

@mergennachin mergennachin added this to the 1.0.0 milestone Sep 11, 2025
@mergennachin
Copy link
Contributor

@shoumikhin we want this to be in by 1.0 branch cut

@shoumikhin @facebook-github-bot
Let's not expose the underlying Method. (pytorch#13543)
5d2c5e2 
Summary:

.

Reviewed By: JacobSzwejbka, mergennachin

Differential Revision: D80595270
@facebook-github-bot
Copy link
Contributor

@shoumikhin has exported this pull request. If you are a Meta employee, you can view the originating diff in D80595270.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mergennachin mergennachin mergennachin approved these changes

@JacobSzwejbka JacobSzwejbka JacobSzwejbka approved these changes

@jackzhxng jackzhxng Awaiting requested review from jackzhxng

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820

@swolchok swolchok Awaiting requested review from swolchok

@lucylq lucylq Awaiting requested review from lucylq

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@shoumikhin @facebook-github-bot @mergennachin @JacobSzwejbka