Skip to content

Let's not expose the underlying Method. #13543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Let's not expose the underlying Method. #13543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions extension/module/module.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,12 +215,6 @@ runtime::Error Module::load_method(
return runtime::Error::Ok;
}

ET_NODISCARD runtime::Result<Method*> Module::method(
const std::string& method_name) {
ET_CHECK_OK_OR_RETURN_ERROR(load_method(method_name));
return methods_[method_name].method.get();
}

runtime::Result<MethodMeta> Module::method_meta(
const std::string& method_name) {
ET_CHECK_OK_OR_RETURN_ERROR(load());
Expand Down
15 changes: 0 additions & 15 deletions extension/module/module.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,21 +205,6 @@ class Module {
return methods_.erase(method_name);
}

/**
* DEPRECATED: Module manages each Method exclusively.
*
* Get a method by it's name. Not recommended to use this method directly as
* an end user. It's exposed to allow for composability of module in apis that
* operate on method.
*
* @param[in] method_name The name of the method to get.
*
* @returns A Result object containing either a pointer to the requested
* method or an error to indicate failure.
*/
ET_DEPRECATED ET_NODISCARD runtime::Result<Method*> method(
const std::string& method_name);

/**
* Load the 'forward' method from the program and set up memory management if
* needed. The loaded method is cached to reuse the next time it's executed.
Expand Down
Loading