Skip to content

Build an AAR with QNN #13687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 27, 2025
Merged

Build an AAR with QNN #13687

merged 8 commits into from
Aug 27, 2025

Conversation

kirklandsign
Copy link
Contributor

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 26, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13687

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 1 Pending, 1 Unrelated Failure

As of commit e33b65f with merge base 785d298 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 26, 2025
cccclai
cccclai reviewed Aug 26, 2025
View reviewed changes
.github/workflows/android-release-artifacts.yml Outdated
PYTHON_EXECUTABLE=python bash .ci/scripts/setup-qnn-deps.sh
PYTHON_EXECUTABLE=python bash .ci/scripts/build-qnn-sdk.sh
export EXECUTORCH_BUILD_QNN=ON
export QNN_SDK_ROOT=/tmp/qnn/2.28.0.241029
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try to reduce the hardcode version and refer to this https://github.com/pytorch/executorch/blob/main/backends/qualcomm/scripts/qnn_config.sh ? If it needs to refactor a bit that's fine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh... This is part of docker image anyways..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah I just meant this part /tmp/qnn/2.28.0.241029, the 2.28.0.241029 can be different when we bump the qnn version

@kirklandsign kirklandsign changed the title qnn? Build an AAR with QNN Aug 26, 2025
@kirklandsign kirklandsign marked this pull request as ready for review August 26, 2025 19:20
kimishpatel
kimishpatel reviewed Aug 26, 2025
View reviewed changes
Copy link
Contributor

@kimishpatel kimishpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hansong. This looks like the right approach. But I was trying to validate something similar and it doesnt quite seem to work yet. One thing is that libQnnModelDlc.so is not distributed in the maven package. I am gonna ask qualcomm to publish one

@kirklandsign kirklandsign added release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. release notes: android Android Java and JNI code and removed release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. labels Aug 27, 2025
@kirklandsign kirklandsign merged commit e2a6538 into main Aug 27, 2025
119 of 128 checks passed
@kirklandsign kirklandsign deleted the qnn-build branch August 27, 2025 23:06
mergennachin
mergennachin reviewed Aug 27, 2025
View reviewed changes
.github/workflows/android-release-artifacts.yml
source backends/qualcomm/scripts/qnn_config.sh
export QNN_SDK_ROOT="/tmp/qnn/${QNN_VERSION}"
export ANDROID_ABIS=arm64-v8a
GRADLE_ARGS+=" -DqnnVersion=2.28.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @cccclai make sure to update this when you update the QNN version

@cccclai cccclai mentioned this pull request Aug 28, 2025
Merged
@kirklandsign
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/0.7 -c release

pytorchbot pushed a commit that referenced this pull request Sep 2, 2025
@kirklandsign @pytorchbot
Build an AAR with QNN (#13687)
3ee23cb 
(cherry picked from commit e2a6538)
@pytorchbot
Copy link
Collaborator

Cherry picking #13687

The cherry pick PR is at #13878

Details for Dev Infra team Raised by workflow job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergennachin mergennachin mergennachin left review comments

@cccclai cccclai cccclai left review comments

@kimishpatel kimishpatel kimishpatel approved these changes

@GregoryComer GregoryComer Awaiting requested review from GregoryComer GregoryComer is a code owner

@swolchok swolchok Awaiting requested review from swolchok swolchok is a code owner

@digantdesai digantdesai Awaiting requested review from digantdesai

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: android Android Java and JNI code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kirklandsign @pytorchbot @mergennachin @cccclai @kimishpatel