Add extra logging in CoreML #13890
Merged
Add extra logging in CoreML #13890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff adds extra logging in CoreML to indicate whether the model in the pte file was pre-compiled. Differential Revision: D81256207
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13890
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 1 Cancelled Job, 2 Unrelated FailuresAs of commit cad826f with merge base 6c1ef96 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D81256207 |
This PR needs a
|
Contributor
Author
|
@cymbalrush can you take a look at this PR to add extra logging to the CoreML delegate? |
mergennachin
approved these changes
Sep 3, 2025
Contributor
|
Looks good, thank you! |
metascroy
added a commit
to metascroy/executorch
that referenced
this pull request
Sep 16, 2025
Summary: Original commit changeset: ae667b071853 Original Phabricator Diff: D81256207 Since the introduction of D80715432, WhatsApp is seeing an increase in model load failures with error code 0x23 (P1948468840). From logs, the underlying issue is something like "Model init failed “model.mlmodelc” couldn’t be moved to “models” because an item with the same name already exists." FB app has also seen an increase in error code 0x23 since 9/5. We are unable to reproduce this error locally, but out of caution we want to revert D80715432 and see if the errors resolve. Since D80715432 landed, we also landed D81256207 to add more logging. To prevent conflicts, we backout in 3 steps: * In diff 1/3, we backout D81256207, which added more logging * In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert * In diff 3/3, we introduce some of the logging we backed out in diff 1/3 Differential Revision: D82581442
metascroy
added a commit
to metascroy/executorch
that referenced
this pull request
Sep 16, 2025
Summary: Original commit changeset: ae667b071853 Original Phabricator Diff: D81256207 Since the introduction of D80715432, WhatsApp is seeing an increase in model load failures with error code 0x23 (P1948468840). From logs, the underlying issue is something like "Model init failed “model.mlmodelc” couldn’t be moved to “models” because an item with the same name already exists." FB app has also seen an increase in error code 0x23 since 9/5. We are unable to reproduce this error locally, but out of caution we want to revert D80715432 and see if the errors resolve. Since D80715432 landed, we also landed D81256207 to add more logging. To prevent conflicts, we backout in 3 steps: * In diff 1/3, we backout D81256207, which added more logging * In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert * In diff 3/3, we introduce some of the logging we backed out in diff 1/3 Differential Revision: D82581442
metascroy
added a commit
to metascroy/executorch
that referenced
this pull request
Sep 16, 2025
Summary: Original commit changeset: ae667b071853 Original Phabricator Diff: D81256207 Since the introduction of D80715432, WhatsApp is seeing an increase in model load failures with error code 0x23 (P1948468840). From logs, the underlying issue is something like "Model init failed “model.mlmodelc” couldn’t be moved to “models” because an item with the same name already exists." FB app has also seen an increase in error code 0x23 since 9/5. We are unable to reproduce this error locally, but out of caution we want to revert D80715432 and see if the errors resolve. Since D80715432 landed, we also landed D81256207 to add more logging. To prevent conflicts, we backout in 3 steps: * In diff 1/3, we backout D81256207, which added more logging * In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert * In diff 3/3, we introduce some of the logging we backed out in diff 1/3 Differential Revision: D82581442
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 17, 2025
Differential Revision: D82581442 Pull Request resolved: #14353
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
Differential Revision: D82581442 Pull Request resolved: pytorch#14353
pytorchbot
pushed a commit
that referenced
this pull request
Sep 25, 2025
GregoryComer
pushed a commit
that referenced
this pull request
Sep 26, 2025
Summary: Original commit changeset: ae667b071853 Original Phabricator Diff: D81256207 * In diff 1/3, we backout D81256207, which added more logging * In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert * In diff 3/3, we introduce some of the logging we backed out in diff 1/3 Differential Revision: D82581442 Co-authored-by: Scott Roy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff adds extra logging in CoreML to indicate whether the model in the pte file was pre-compiled.
Differential Revision: D81256207