Skip to content

Conversation

@metascroy
Copy link
Contributor

Summary:
This PR:

  • Moves torchao/experimental/kernels -> torchao/csrc/cpu/torch_free_kernels. This directory houses CPU kernels that do not depend on torch and are written with raw pointers.

  • Moves torchao/experimental/ops -> torchao/csrc/cpu/shared_kernels. This directory houses CPU kernels that are shared between ATen and ExecuTorch, and can be built for either runtime based on compile-time flags.

In addition, it:

  • Fixes include paths and CMake files to make the above changes buildable.
  • Adjusts setup.py

The PR is on the larger side, but most changes are not meaningful. For review, I suggest focusing on the changes to setup.py.

X-link: pytorch/ao#2868

Reviewed By: kimishpatel

Differential Revision: D80958790

Pulled By: metascroy

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13920

Note: Links to docs will display an error until the docs builds have been completed.

❌ 93 New Failures, 3 Pending

As of commit 79e1285 with merge base ab44d06 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 3, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80958790

Copy link
Contributor

@kimishpatel kimishpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@github-actions
Copy link

github-actions bot commented Sep 3, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80958790

metascroy added a commit to metascroy/executorch that referenced this pull request Sep 3, 2025
Summary:
Pull Request resolved: pytorch#13920

This PR:

* Moves torchao/experimental/kernels -> torchao/csrc/cpu/torch_free_kernels.  This directory houses CPU kernels that do not depend on torch and are written with raw pointers.

* Moves torchao/experimental/ops -> torchao/csrc/cpu/shared_kernels.  This directory houses CPU kernels that are shared between ATen and ExecuTorch, and can be built for either runtime based on compile-time flags.

In addition, it:

* Fixes include paths and CMake files to make the above changes buildable.
* Adjusts setup.py

The PR is on the larger side, but most changes are not meaningful.  For review, I suggest focusing on the changes to setup.py.

X-link: pytorch/ao#2868

Test Plan: CI tests

Reviewed By: kimishpatel

Differential Revision: D80958790

Pulled By: metascroy
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80958790

@metascroy metascroy closed this Sep 4, 2025
metascroy added a commit to pytorch/ao that referenced this pull request Sep 4, 2025
Summary:
X-link: pytorch/executorch#13920

This PR:

* Moves torchao/experimental/kernels -> torchao/csrc/cpu/torch_free_kernels.  This directory houses CPU kernels that do not depend on torch and are written with raw pointers.

* Moves torchao/experimental/ops -> torchao/csrc/cpu/shared_kernels.  This directory houses CPU kernels that are shared between ATen and ExecuTorch, and can be built for either runtime based on compile-time flags.

In addition, it:

* Fixes include paths and CMake files to make the above changes buildable.
* Adjusts setup.py

The PR is on the larger side, but most changes are not meaningful.  For review, I suggest focusing on the changes to setup.py.

Pull Request resolved: #2868

Test Plan: CI tests

Reviewed By: kimishpatel

Differential Revision: D80958790

Pulled By: metascroy
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80958790

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80958790

@facebook-github-bot facebook-github-bot temporarily deployed to upload-benchmark-results September 4, 2025 06:32 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants