-
Notifications
You must be signed in to change notification settings - Fork 743
Move CPU kernels out of experimental #13920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13920
Note: Links to docs will display an error until the docs builds have been completed. ❌ 93 New Failures, 3 PendingAs of commit 79e1285 with merge base ab44d06 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D80958790 |
kimishpatel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review automatically exported from Phabricator review in Meta.
This PR needs a
|
|
This pull request was exported from Phabricator. Differential Revision: D80958790 |
Summary: Pull Request resolved: pytorch#13920 This PR: * Moves torchao/experimental/kernels -> torchao/csrc/cpu/torch_free_kernels. This directory houses CPU kernels that do not depend on torch and are written with raw pointers. * Moves torchao/experimental/ops -> torchao/csrc/cpu/shared_kernels. This directory houses CPU kernels that are shared between ATen and ExecuTorch, and can be built for either runtime based on compile-time flags. In addition, it: * Fixes include paths and CMake files to make the above changes buildable. * Adjusts setup.py The PR is on the larger side, but most changes are not meaningful. For review, I suggest focusing on the changes to setup.py. X-link: pytorch/ao#2868 Test Plan: CI tests Reviewed By: kimishpatel Differential Revision: D80958790 Pulled By: metascroy
3ed3203 to
79e1285
Compare
|
This pull request was exported from Phabricator. Differential Revision: D80958790 |
79e1285 to
e9e868c
Compare
Summary: X-link: pytorch/executorch#13920 This PR: * Moves torchao/experimental/kernels -> torchao/csrc/cpu/torch_free_kernels. This directory houses CPU kernels that do not depend on torch and are written with raw pointers. * Moves torchao/experimental/ops -> torchao/csrc/cpu/shared_kernels. This directory houses CPU kernels that are shared between ATen and ExecuTorch, and can be built for either runtime based on compile-time flags. In addition, it: * Fixes include paths and CMake files to make the above changes buildable. * Adjusts setup.py The PR is on the larger side, but most changes are not meaningful. For review, I suggest focusing on the changes to setup.py. Pull Request resolved: #2868 Test Plan: CI tests Reviewed By: kimishpatel Differential Revision: D80958790 Pulled By: metascroy
|
This pull request was exported from Phabricator. Differential Revision: D80958790 |
|
This pull request was exported from Phabricator. Differential Revision: D80958790 |
Summary:
This PR:
Moves torchao/experimental/kernels -> torchao/csrc/cpu/torch_free_kernels. This directory houses CPU kernels that do not depend on torch and are written with raw pointers.
Moves torchao/experimental/ops -> torchao/csrc/cpu/shared_kernels. This directory houses CPU kernels that are shared between ATen and ExecuTorch, and can be built for either runtime based on compile-time flags.
In addition, it:
The PR is on the larger side, but most changes are not meaningful. For review, I suggest focusing on the changes to setup.py.
X-link: pytorch/ao#2868
Reviewed By: kimishpatel
Differential Revision: D80958790
Pulled By: metascroy