Skip to content

Fix missing kernel header in stack util #14069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jathu merged 1 commit into from
Sep 9, 2025
Merged

Fix missing kernel header in stack util #14069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions kernels/portable/cpu/util/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,8 @@ def define_common_targets():
exported_headers = ["stack_util.h"],
deps = [
"//executorch/kernels/portable/cpu/util:copy_ops_util",
],
exported_deps = [
Copy link
Contributor

@manuelcandales manuelcandales Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why exported_deps rather than adding it to the list of deps?

Copy link
Contributor Author

@jathu jathu Sep 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is due to GitHub's poor diff UI, but it currently exists in deps. I am moving it to external_deps

executorch/kernels/portable/cpu/util/targets.bzl

Lines 299 to 308 in ea37202

runtime.cxx_library(
name = "stack_util",
srcs = ["stack_util.cpp"],
exported_headers = ["stack_util.h"],
deps = [
"//executorch/kernels/portable/cpu/util:copy_ops_util",
"//executorch/runtime/kernel:kernel_includes",
],
visibility = ["//executorch/kernels/portable/cpu/...", "@EXECUTORCH_CLIENTS"],
)

"//executorch/runtime/kernel:kernel_includes",
],
visibility = ["//executorch/kernels/portable/cpu/...", "@EXECUTORCH_CLIENTS"],
Expand Down
Loading