Fix missing kernel header in stack util #14069
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14069
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 6866011 with merge base 0eb4361 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D81930473 |
Summary: Given `stack_util.h` is exported and it includes `kernel_includes.h`, we need `kernel_includes` in the build dependency. One solution is to expect the clients who use `slice_util` to also add `kernel_includes`. However, "doing it for them" via exported_deps seems like a nicer solution. Reviewed By: silverguo Differential Revision: D81930473
jathu
force-pushed
the
export-D81930473
branch
from
0e73d25 to
51bcb66
Compare
Summary: Pull Request resolved: #14069 Given `stack_util.h` is exported and it includes `kernel_includes.h`, we need `kernel_includes` in the build dependency. One solution is to expect the clients who use `slice_util` to also add `kernel_includes`. However, "doing it for them" via exported_deps seems like a nicer solution. Reviewed By: silverguo Differential Revision: D81930473
|
This pull request was exported from Phabricator. Differential Revision: D81930473 |
jathu
force-pushed
the
export-D81930473
branch
from
51bcb66 to
6866011
Compare
| deps = [ | ||
| "//executorch/kernels/portable/cpu/util:copy_ops_util", | ||
| ], | ||
| exported_deps = [ |
There was a problem hiding this comment.
why exported_deps rather than adding it to the list of deps?
There was a problem hiding this comment.
I think this is due to GitHub's poor diff UI, but it currently exists in deps. I am moving it to external_deps
executorch/kernels/portable/cpu/util/targets.bzl
Lines 299 to 308 in ea37202
Summary:
Given
stack_util.his exported and it includeskernel_includes.h, we needkernel_includesin the build dependency.One solution is to expect the clients who use
slice_utilto also addkernel_includes. However, "doing it for them" via exported_deps seems like a nicer solution.Reviewed By: silverguo
Differential Revision: D81930473