Arm backend: Refactor compile spec handling (Try 2) #14191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mergennachin merged 1 commit into pytorch:main from mergennachin:export-D82171193

Sep 12, 2025

Contributor

mergennachin commented Sep 11, 2025 •

edited by pytorch-bot bot

Loading

Summary: Redoing #14111 with additional fixes

Differential Revision: D82171193

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

mergennachin requested a review from digantdesai as a code owner

September 11, 2025 01:10

pytorch-bot bot commented Sep 11, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14191

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 258 Pending

As of commit 4b081fe with merge base 323a9e8 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-cla bot added the CLA Signed label

Contributor

facebook-github-bot commented Sep 11, 2025

This pull request was exported from Phabricator. Differential Revision: D82171193

facebook-github-bot added the fb-exported label

mergennachin requested a review from swolchok

September 11, 2025 01:17

mergennachin added partner: arm release notes: arm release notes: api labels

mergennachin requested review from Erik-Lundell and zingo

September 11, 2025 01:23

Contributor

facebook-github-bot commented Sep 11, 2025

This pull request was exported from Phabricator. Differential Revision: D82171193

mergennachin added a commit to mergennachin/executorch-1 that referenced this pull request


          Arm backend: Refactor compile spec handling (Try 2) (pytorch#14191)

dcd46a8

Summary:
Pull Request resolved: pytorch#14191

Redoing pytorch#14111 with additional fixes

Differential Revision: D82171193

mergennachin force-pushed the export-D82171193 branch from 2d006c7 to dcd46a8 Compare

September 11, 2025 02:38

Contributor

facebook-github-bot commented Sep 11, 2025

This pull request was exported from Phabricator. Differential Revision: D82171193

mergennachin added a commit to mergennachin/executorch-1 that referenced this pull request


          Arm backend: Refactor compile spec handling (Try 2) (pytorch#14191)

8a9cf5e

Summary:
Pull Request resolved: pytorch#14191

Redoing pytorch#14111 with additional fixes

Differential Revision: D82171193

mergennachin force-pushed the export-D82171193 branch from dcd46a8 to 8a9cf5e Compare

September 11, 2025 02:45

Contributor

facebook-github-bot commented Sep 11, 2025

This pull request was exported from Phabricator. Differential Revision: D82171193

mergennachin added a commit to mergennachin/executorch-1 that referenced this pull request


          Arm backend: Refactor compile spec handling (Try 2) (pytorch#14191)

2cb36eb

Summary:
Pull Request resolved: pytorch#14191

Redoing pytorch#14111 with additional fixes

Differential Revision: D82171193

mergennachin force-pushed the export-D82171193 branch from 8a9cf5e to 2cb36eb Compare

September 11, 2025 03:09

Contributor

facebook-github-bot commented Sep 11, 2025

This pull request was exported from Phabricator. Differential Revision: D82171193

mergennachin added a commit to mergennachin/executorch-1 that referenced this pull request


          Arm backend: Refactor compile spec handling (Try 2) (pytorch#14191)

50aa04a

Summary:
Pull Request resolved: pytorch#14191

Redoing pytorch#14111 with additional fixes

Differential Revision: D82171193

mergennachin force-pushed the export-D82171193 branch from 2cb36eb to 50aa04a Compare

September 11, 2025 03:16

Contributor

facebook-github-bot commented Sep 11, 2025

This pull request was exported from Phabricator. Differential Revision: D82171193

mergennachin added a commit to mergennachin/executorch-1 that referenced this pull request


          Arm backend: Refactor compile spec handling (Try 2) (pytorch#14191)

e5397b5

Summary:
Pull Request resolved: pytorch#14191

Redoing pytorch#14111 with additional fixes

Differential Revision: D82171193

mergennachin force-pushed the export-D82171193 branch from 50aa04a to e5397b5 Compare

September 11, 2025 03:27

Contributor

facebook-github-bot commented Sep 11, 2025

This pull request was exported from Phabricator. Differential Revision: D82171193

mergennachin force-pushed the export-D82171193 branch from e5397b5 to e221b8d Compare

September 11, 2025 11:39

mergennachin added a commit to mergennachin/executorch-1 that referenced this pull request


          Arm backend: Refactor compile spec handling (Try 2) (pytorch#14191)

e221b8d

Summary:
Pull Request resolved: pytorch#14191

Redoing pytorch#14111 with additional fixes

Differential Revision: D82171193

Contributor

facebook-github-bot commented Sep 11, 2025

This pull request was exported from Phabricator. Differential Revision: D82171193

mergennachin added this to the 1.0.0 milestone

digantdesai approved these changes

View reviewed changes

Contributor

digantdesai left a comment

Approved!!

mergennachin added the ciflow/trunk label

Contributor

facebook-github-bot commented Sep 11, 2025

This pull request was exported from Phabricator. Differential Revision: D82171193

mergennachin force-pushed the export-D82171193 branch from 67e8585 to 6c89cbe Compare

September 11, 2025 21:28

mergennachin added a commit to mergennachin/executorch-1 that referenced this pull request


          Arm backend: Refactor compile spec handling (Try 2) (pytorch#14191)

6c89cbe

Summary:
Pull Request resolved: pytorch#14191

Redoing pytorch#14111 with additional fixes

Reviewed By: digantdesai

Differential Revision: D82171193

swolchok reviewed

View reviewed changes

backends/arm/TARGETS Outdated

Comment on lines 67 to 73

    
              runtime.python_library(

                  name = "tosa_compile_spec",

                  srcs = [

                      "tosa/__init__.py",

                      "tosa/compile_spec.py",

                  ],

                  deps = [

Contributor

swolchok Sep 11, 2025

I recommend moving this into tosa/TARGETS so you can reference these files

backends/arm/TARGETS

Comment on lines +82 to +73

    
                      "vgf/__init__.py",

                      "vgf/backend.py",

                      "vgf/compile_spec.py",

                      "vgf/partitioner.py",

Contributor

swolchok Sep 11, 2025

this is fine as long as vgf/TARGETS doesn't exist

Contributor

facebook-github-bot commented Sep 11, 2025

@mergennachin has exported this pull request. If you are a Meta employee, you can view the originating diff in D82171193.

facebook-github-bot added the meta-exported label

mergennachin added a commit to mergennachin/executorch-1 that referenced this pull request


          Arm backend: Refactor compile spec handling (Try 2) (pytorch#14191)

d9493ff

Summary:
Pull Request resolved: pytorch#14191

Redoing pytorch#14111 with additional fixes

Reviewed By: digantdesai

Differential Revision: D82171193

mergennachin force-pushed the export-D82171193 branch from 6c89cbe to d9493ff Compare

September 11, 2025 22:24

Contributor

facebook-github-bot commented Sep 11, 2025

@mergennachin has exported this pull request. If you are a Meta employee, you can view the originating diff in D82171193.

mergennachin added a commit to mergennachin/executorch-1 that referenced this pull request


          Arm backend: Refactor compile spec handling (Try 2) (pytorch#14191)

861e98a

Summary:
Pull Request resolved: pytorch#14191

Redoing pytorch#14111 with additional fixes

Reviewed By: digantdesai

Differential Revision: D82171193

mergennachin force-pushed the export-D82171193 branch from d9493ff to 861e98a Compare

September 11, 2025 22:33

AdrianLundell added a commit to AdrianLundell/executorch that referenced this pull request


          Arm backend: Update backends-arm-ethos-u.md.

f5c68ac

Update the doc to be more focused on detailed API documentation.

Note that this documents the change introduced in pytorch#14191.

Signed-off-by: Adrian Lundell <[email protected]>
Change-Id: Iebfd537e038ce3517cd5c5158bcec311b7d2b258

AdrianLundell mentioned this pull request

Arm backend: Update backends-arm-ethos-u.md. #14255

Merged

zingo mentioned this pull request

Arm backend: make compile_spec API backwards compatible #14209

Closed

agrima1304 mentioned this pull request

Arm Backend: Create backends-arm-vgf.md #14261

Merged


          Arm backend: Refactor compile spec handling (Try 2)

4b081fe

Summary: Redoing pytorch#14111 with additional fixes

Reviewed By: digantdesai

Differential Revision: D82171193

Contributor

facebook-github-bot commented Sep 12, 2025

@mergennachin has exported this pull request. If you are a Meta employee, you can view the originating diff in D82171193.

1 similar comment

Contributor

facebook-github-bot commented Sep 12, 2025

@mergennachin has exported this pull request. If you are a Meta employee, you can view the originating diff in D82171193.

mergennachin force-pushed the export-D82171193 branch from 861e98a to 4b081fe Compare

September 12, 2025 18:17

mergennachin merged commit 8da4a6e into pytorch:main

288 of 300 checks passed

mergennachin deleted the export-D82171193 branch

September 12, 2025 18:43

mergennachin pushed a commit that referenced this pull request


          Arm backend: Update backends-arm-ethos-u.md. (#14255)

f82d94b

Update the doc to be more focused on detailed API documentation.

Note that this documents the change introduced in #14191.

---------

Signed-off-by: Adrian Lundell <[email protected]>

mergennachin pushed a commit that referenced this pull request


          Arm Backend: Create backends-arm-vgf.md (#14261)

50ac8ea

Create the documentation for the VGF backend.

This includes the change introduced in #14191 .

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

---------

Signed-off-by: Agrima Khare <[email protected]>

zingo mentioned this pull request

Arm backend: Support channels-last input and output #14259

Merged

StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request


          Arm backend: Refactor compile spec handling (Try 2) (pytorch#14191)

Summary: Redoing pytorch#14111 with
additional fixes

Differential Revision: D82171193


cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request


          Arm backend: Update backends-arm-ethos-u.md. (pytorch#14255)

4b723c3

Update the doc to be more focused on detailed API documentation.

Note that this documents the change introduced in pytorch#14191.

---------

Signed-off-by: Adrian Lundell <[email protected]>

StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request


          Arm Backend: Create backends-arm-vgf.md (pytorch#14261)

c0b18fb

Create the documentation for the VGF backend.

This includes the change introduced in pytorch#14191 .

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

---------

Signed-off-by: Agrima Khare <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed fb-exported meta-exported partner: arm release notes: api release notes: arm