Arm backend: Convert remaining asserts to exceptions in tosa/ #14369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sebastian-Larsson
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14369
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit 33f86a0 with merge base 8da822c ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
digantdesai
reviewed
Sep 17, 2025
digantdesai
approved these changes
Sep 17, 2025
Collaborator
|
Needs rebase :( |
Change-Id: If75c5649e1090f671a212551ffd9e1c5c2546f09 Signed-off-by: Sebastian Larsson <[email protected]>
Sebastian-Larsson
force-pushed
the
convert_asserts
branch
from
4e46c6a to
13e3211
Compare
Collaborator
Author
|
Unrelated CI failures |
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
…h#14369) In `tosa/quant_utils.py`, add message to assert. In `tosa/backend.py` and `tosa/mapping.py` convert asserts to exceptions. Signed-off-by: Sebastian Larsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
tosa/quant_utils.py, add message to assert.In
tosa/backend.pyandtosa/mapping.pyconvert asserts to exceptions.cc @digantdesai @freddan80 @per @zingo @oscarandersson8218