Update usages of DataLoader::SegmentInfo::Type::External #15195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update usages of `SegmentInfo::Type::External` to reflect the same segments that PTE uses, instead of using `External` for any part of the PTD . Specifically: 1. Program: PTD header and flatbuffer portion 2. Constant: when loading items using the `get_data` API 3. Mutable: when loading items using the `load_data_into` API Differential Revision: [D83671426](https://our.internmc.facebook.com/intern/diff/D83671426/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15195
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 0675426 with merge base f8e199c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
lucylq
added a commit
that referenced
this pull request
Oct 16, 2025
Update usages of `SegmentInfo::Type::External` to reflect the same segments that PTE uses, instead of using `External` for any part of the PTD . Specifically: 1. Program: PTD header and flatbuffer portion 2. Constant: when loading items using the `get_data` API 3. Mutable: when loading items using the `load_data_into` API Differential Revision: [D83671426](https://our.internmc.facebook.com/intern/diff/D83671426/) ghstack-source-id: 313373765 Pull Request resolved: #15195
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
Update usages of `SegmentInfo::Type::External` to reflect the same segments that PTE uses, instead of using `External` for any part of the PTD . Specifically: 1. Program: PTD header and flatbuffer portion 2. Constant: when loading items using the `get_data` API 3. Mutable: when loading items using the `load_data_into` API Differential Revision: [D83671426](https://our.internmc.facebook.com/intern/diff/D83671426/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Oct 16, 2025
Pull Request resolved: #15195 Update usages of `SegmentInfo::Type::External` to reflect the same segments that PTE uses, instead of using `External` for all parts of the PTD . Specifically: 1. Program: PTD header and flatbuffer portion 2. Constant: when loading items using the `get_data` API 3. Mutable: when loading items using the `load_data_into` API ghstack-source-id: 316716581 @exported-using-ghexport Differential Revision: [D83671426](https://our.internmc.facebook.com/intern/diff/D83671426/)
JacobSzwejbka
approved these changes
Oct 17, 2025
meta-codesync
bot
merged commit 926f728
into
gh/lucylq/120/base
147 of 150 checks passed
lucylq
added a commit
that referenced
this pull request
Oct 24, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #15195 by @lucylq ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/120/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/120/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/120/orig Differential Revision: [D83671426](https://our.internmc.facebook.com/intern/diff/D83671426/) @diff-train-skip-merge Co-authored-by: lucylq <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Update usages of
SegmentInfo::Type::Externalto reflect the same segments that PTE uses, instead of usingExternalfor any part of the PTD . Specifically:get_dataAPIload_data_intoAPIDifferential Revision: D83671426