Skip to content

Update usages of DataLoader::SegmentInfo::Type::External #15195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2025
Merged

Update usages of DataLoader::SegmentInfo::Type::External #15195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95367a8
Update usages of DataLoader::SegmentInfo::Type::External
lucylq Oct 16, 2025
0675426
Update on "Update usages of DataLoader::SegmentInfo::Type::External"
lucylq Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions extension/flat_tensor/flat_tensor_data_map.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ ET_NODISCARD Result<FreeableBuffer> FlatTensorDataMap::get_data(
return loader_->load(
/*offset=*/header_.segment_base_offset + segment_offset,
segment_size,
DataLoader::SegmentInfo(DataLoader::SegmentInfo::Type::External));
DataLoader::SegmentInfo(DataLoader::SegmentInfo::Type::Constant));
}

ET_NODISCARD Error FlatTensorDataMap::load_data_into(
Expand Down Expand Up @@ -201,7 +201,7 @@ ET_NODISCARD Result<const char*> FlatTensorDataMap::get_key(
Result<FreeableBuffer> header = loader->load(
/*offset=*/0,
FlatTensorHeader::kNumHeadBytes,
DataLoader::SegmentInfo(DataLoader::SegmentInfo::Type::External));
DataLoader::SegmentInfo(DataLoader::SegmentInfo::Type::Program));
if (!header.ok()) {
ET_LOG(Error, "Failed to load header.");
return header.error();
Expand All @@ -228,7 +228,7 @@ ET_NODISCARD Result<const char*> FlatTensorDataMap::get_key(
Result<FreeableBuffer> flat_tensor_data = loader->load(
/*offset=*/0,
fh->flatbuffer_offset + fh->flatbuffer_size,
DataLoader::SegmentInfo(DataLoader::SegmentInfo::Type::External));
DataLoader::SegmentInfo(DataLoader::SegmentInfo::Type::Program));
if (!flat_tensor_data.ok()) {
ET_LOG(Error, "Failed to load flat_tensor data.");
return flat_tensor_data.error();
Expand Down
2 changes: 1 addition & 1 deletion extension/flat_tensor/test/flat_tensor_data_map_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ TEST_F(FlatTensorDataMapTest, LoadAndCheckSize) {
Result<FreeableBuffer> truncated_file = data_map_loader_->load(
0,
trunc_size,
DataLoader::SegmentInfo(DataLoader::SegmentInfo::Type::External));
DataLoader::SegmentInfo(DataLoader::SegmentInfo::Type::Constant));
ASSERT_EQ(truncated_file.error(), Error::Ok);

BufferDataLoader truncated_loader =
Expand Down
2 changes: 1 addition & 1 deletion extension/training/module/test/state_dict_util_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class LoadStateDictTest : public ::testing::Test {
/*offset=*/0,
FlatTensorHeader::kNumHeadBytes,
/*segment_info=*/
DataLoader::SegmentInfo(DataLoader::SegmentInfo::Type::External));
DataLoader::SegmentInfo(DataLoader::SegmentInfo::Type::Program));

ASSERT_EQ(header.error(), Error::Ok);

Expand Down
2 changes: 1 addition & 1 deletion runtime/executor/pte_data_map.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Result<FreeableBuffer> PteDataMap::get_data(
return loader_->load(
/*offset=*/segment_base_offset_ + segment_offset,
segment_size,
DataLoader::SegmentInfo(DataLoader::SegmentInfo::Type::External));
DataLoader::SegmentInfo(DataLoader::SegmentInfo::Type::Constant));
}
}
return Error::NotFound;
Expand Down
Loading