Properly set modified for variety of cadence passes #15471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15471
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 4 Unrelated FailuresAs of commit 0f6fb47 with merge base 3e9629a ( CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
DrJessop
force-pushed
the
export-D85817305
branch
from
c33ea4c to
9d3a28d
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Nov 3, 2025
Summary: Devmate generated diff where I asked it to update a large batch of passes which only override call_operator with pattern defined in D85815510 Differential Revision: D85817305
DrJessop
force-pushed
the
export-D85817305
branch
from
9d3a28d to
81ce91e
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Nov 5, 2025
Summary: Devmate generated diff where I asked it to update a large batch of passes to use the new remove or replace interface Differential Revision: D85817305
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Nov 5, 2025
Summary: Update a large batch of passes to use the new remove or replace interface Differential Revision: D85817305
DrJessop
force-pushed
the
export-D85817305
branch
from
81ce91e to
fe580af
Compare
DrJessop
pushed a commit
to DrJessop/executorch
that referenced
this pull request
Nov 5, 2025
…orch#15471) Summary: Update a large batch of passes to use the new remove or replace interface Differential Revision: D85817305
DrJessop
force-pushed
the
export-D85817305
branch
from
fe580af to
ef86afb
Compare
abeakkas
approved these changes
Nov 5, 2025
Contributor
abeakkas
left a comment
abeakkas
left a comment
There was a problem hiding this comment.
With pending Phabricator comment.
…orch#15471) Summary: Update a large batch of passes to use the new remove or replace interface Reviewed By: abeakkas Differential Revision: D85817305
DrJessop
force-pushed
the
export-D85817305
branch
from
ef86afb to
0f6fb47
Compare
abhinaykukkadapu
pushed a commit
to abhinaykukkadapu/executorch
that referenced
this pull request
Nov 6, 2025
Differential Revision: D85817305 Pull Request resolved: pytorch#15471
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Update a large batch of passes to use the new remove or replace interface
Differential Revision: D85817305