-
Notifications
You must be signed in to change notification settings - Fork 794
[executorch] Remove EXECUTORCH_CLIENTS visibility gating - Other Backends #16478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[executorch] Remove EXECUTORCH_CLIENTS visibility gating - Other Backends #16478
Conversation
…ends Remove the EXECUTORCH_CLIENTS buck client list visibility gating from additional backend targets. This replaces all visibility blocks containing @EXECUTORCH_CLIENTS with explicit PUBLIC visibility. This is part 5 of a multi-diff stack to remove visibility gating across all of executorch. This diff covers: - backends/aoti - backends/apple (coreml, mps) - backends/arm - backends/cadence - backends/cortex_m - backends/cuda - backends/nxp - backends/qualcomm - backends/test - backends/transforms Differential Revision: [D89902029](https://our.internmc.facebook.com/intern/diff/D89902029/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16478
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit d08940f with merge base 09b5bdb ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
… Other Backends" Remove the EXECUTORCH_CLIENTS buck client list visibility gating from additional backend targets. This replaces all visibility blocks containing EXECUTORCH_CLIENTS with explicit PUBLIC visibility. This is part 5 of a multi-diff stack to remove visibility gating across all of executorch. This diff covers: - backends/aoti - backends/apple (coreml, mps) - backends/arm - backends/cadence - backends/cortex_m - backends/cuda - backends/nxp - backends/qualcomm - backends/test - backends/transforms Differential Revision: [D89902029](https://our.internmc.facebook.com/intern/diff/D89902029/) [ghstack-poisoned]
0023865
into
gh/GregoryComer/171/base
Stack from ghstack (oldest at bottom):
Remove the EXECUTORCH_CLIENTS buck client list visibility gating from additional
backend targets. This replaces all visibility blocks containing @EXECUTORCH_CLIENTS
with explicit PUBLIC visibility.
This is part 5 of a multi-diff stack to remove visibility gating across all of executorch.
This diff covers:
Differential Revision: D89902029