Skip to content

Conversation

@GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Jan 6, 2026

Stack from ghstack (oldest at bottom):

Remove the EXECUTORCH_CLIENTS buck client list visibility gating from extension
targets. This replaces all visibility blocks containing @EXECUTORCH_CLIENTS
with explicit PUBLIC visibility.

This is part 6 of a multi-diff stack to remove visibility gating across all of executorch.
This diff covers all extension/*:

  • extension/android
  • extension/aten_util
  • extension/data_loader
  • extension/fb (dynamic_shim, ptez)
  • extension/flat_tensor
  • extension/kernel_util
  • extension/llm
  • extension/memory_allocator
  • extension/module
  • extension/pybindings
  • extension/tensor
  • extension/threadpool
  • extension/training

Differential Revision: D89902030

Remove the EXECUTORCH_CLIENTS buck client list visibility gating from extension
targets. This replaces all visibility blocks containing @EXECUTORCH_CLIENTS
with explicit PUBLIC visibility.

This is part 6 of a multi-diff stack to remove visibility gating across all of executorch.
This diff covers all extension/*:
- extension/android
- extension/aten_util
- extension/data_loader
- extension/fb (dynamic_shim, ptez)
- extension/flat_tensor
- extension/kernel_util
- extension/llm
- extension/memory_allocator
- extension/module
- extension/pybindings
- extension/tensor
- extension/threadpool
- extension/training

Differential Revision: [D89902030](https://our.internmc.facebook.com/intern/diff/D89902030/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 6, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16479

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 4d1edb2 with merge base 09b5bdb (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 6, 2026
… Extensions"

Remove the EXECUTORCH_CLIENTS buck client list visibility gating from extension
targets. This replaces all visibility blocks containing EXECUTORCH_CLIENTS
with explicit PUBLIC visibility.

This is part 6 of a multi-diff stack to remove visibility gating across all of executorch.
This diff covers all extension/*:
- extension/android
- extension/aten_util
- extension/data_loader
- extension/fb (dynamic_shim, ptez)
- extension/flat_tensor
- extension/kernel_util
- extension/llm
- extension/memory_allocator
- extension/module
- extension/pybindings
- extension/tensor
- extension/threadpool
- extension/training

Differential Revision: [D89902030](https://our.internmc.facebook.com/intern/diff/D89902030/)

[ghstack-poisoned]
@meta-codesync meta-codesync bot merged commit 5abacb8 into gh/GregoryComer/172/base Jan 9, 2026
169 of 172 checks passed
@meta-codesync meta-codesync bot deleted the gh/GregoryComer/172/head branch January 9, 2026 23:46
@meta-codesync meta-codesync bot temporarily deployed to cherry-pick-bot January 9, 2026 23:46 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants