Skip to content

[executorch] Remove EXECUTORCH_CLIENTS visibility gating - Extensions #16479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meta-codesync merged 2 commits into from
Jan 9, 2026
Merged

[executorch] Remove EXECUTORCH_CLIENTS visibility gating - Extensions #16479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78287fc
[executorch] Remove EXECUTORCH_CLIENTS visibility gating - Extensions
GregoryComer Jan 6, 2026
4d1edb2
Update on "[executorch] Remove EXECUTORCH_CLIENTS visibility gating -…
GregoryComer Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extension/android/jni/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ non_fbcode_target(_kind = runtime.cxx_library,
deps = [
"//executorch/runtime/core:core",
],
visibility = ["@EXECUTORCH_CLIENTS"],
visibility = ["PUBLIC"],
)

runtime.export_file(
Expand Down
5 changes: 1 addition & 4 deletions extension/aten_util/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,7 @@ def define_common_targets():
"-Wno-global-constructors",
"-Wno-unused-function",
],
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
exported_deps = [
"//executorch/extension/kernel_util:kernel_util",
"//executorch/extension/tensor:tensor",
Expand Down
36 changes: 5 additions & 31 deletions extension/data_loader/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,7 @@ def define_common_targets():
name = "buffer_data_loader",
srcs = [],
exported_headers = ["buffer_data_loader.h"],
visibility = [
"//executorch/exir/backend/test/...",
"//executorch/runtime/executor/test/...",
"//executorch/extension/pybindings/...",
"//executorch/test/...",
"//executorch/extension/data_loader/test/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
exported_deps = [
"//executorch/runtime/core:core",
],
Expand All @@ -28,10 +21,7 @@ def define_common_targets():
name = "shared_ptr_data_loader",
srcs = [],
exported_headers = ["shared_ptr_data_loader.h"],
visibility = [
"@EXECUTORCH_CLIENTS",
"//executorch/extension/data_loader/test/...",
],
visibility = ["PUBLIC"],
exported_deps = [
"//executorch/runtime/core:core",
],
Expand All @@ -41,12 +31,7 @@ def define_common_targets():
name = "file_data_loader",
srcs = ["file_data_loader.cpp"],
exported_headers = ["file_data_loader.h"],
visibility = [
"//executorch/test/...",
"//executorch/runtime/executor/test/...",
"//executorch/extension/data_loader/test/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
exported_deps = [
"//executorch/runtime/core:core",
],
Expand All @@ -56,12 +41,7 @@ def define_common_targets():
name = "file_descriptor_data_loader",
srcs = ["file_descriptor_data_loader.cpp"],
exported_headers = ["file_descriptor_data_loader.h"],
visibility = [
"//executorch/test/...",
"//executorch/runtime/executor/test/...",
"//executorch/extension/data_loader/test/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
exported_deps = [
"//executorch/runtime/core:core",
],
Expand All @@ -83,13 +63,7 @@ def define_common_targets():
"mman.h",
"mmap_data_loader.h"
],
visibility = [
"//executorch/test/...",
"//executorch/extension/pybindings/...",
"//executorch/runtime/executor/test/...",
"//executorch/extension/data_loader/test/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
exported_deps = [
"//executorch/runtime/core:core",
],
Expand Down
2 changes: 1 addition & 1 deletion extension/evalue_util/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def define_common_targets():
name = "print_evalue" + aten_suffix,
srcs = ["print_evalue.cpp"],
exported_headers = ["print_evalue.h"],
visibility = ["@EXECUTORCH_CLIENTS"],
visibility = ["PUBLIC"],
exported_deps = [
"//executorch/runtime/core:evalue" + aten_suffix,
],
Expand Down
7 changes: 1 addition & 6 deletions extension/export_util/TARGETS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,7 @@ runtime.python_library(
"utils.py",
],
_is_external_target = True,
visibility = [
"//bento/...",
"//bento_kernels/...",
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
deps = [
"//caffe2:torch",
"//executorch/exir:lib",
Expand Down
5 changes: 1 addition & 4 deletions extension/flat_tensor/serialize/TARGETS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,7 @@ runtime.python_library(
"flat_tensor.fbs",
"scalar_type.fbs",
],
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
deps = [
":schema",
"//executorch/exir/_serialize:lib",
Expand Down
5 changes: 1 addition & 4 deletions extension/flat_tensor/serialize/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,6 @@ def define_common_targets():
"//executorch/runtime/core/exec_aten:lib",
],
exported_headers = ["serialize.h"],
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
exported_external_deps = ["flatbuffers-api"],
)
4 changes: 1 addition & 3 deletions extension/flat_tensor/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,5 @@ def define_common_targets():
"//executorch/extension/flat_tensor/serialize:flat_tensor_header",
"//executorch/extension/flat_tensor/serialize:generated_headers",
],
visibility = [
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
)
5 changes: 1 addition & 4 deletions extension/kernel_util/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,7 @@ def define_common_targets():
"meta_programming.h",
"type_list.h",
],
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
exported_deps = [
"//executorch/runtime/core:core",
"//executorch/runtime/core:evalue",
Expand Down
2 changes: 1 addition & 1 deletion extension/llm/custom_ops/spinquant/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ def define_common_targets():
exported_deps = [
"//executorch/extension/llm/custom_ops/spinquant/third-party/FFHT:fht",
],
visibility = ["@EXECUTORCH_CLIENTS"],
visibility = ["PUBLIC"],
)
4 changes: 2 additions & 2 deletions extension/llm/custom_ops/spinquant/third-party/FFHT/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ def define_common_targets():
name = "dumb_fht",
srcs = ["dumb_fht.c"],
exported_headers = ["dumb_fht.h"],
visibility = ["@EXECUTORCH_CLIENTS"],
visibility = ["PUBLIC"],
)

runtime.cxx_library(
Expand All @@ -21,7 +21,7 @@ def define_common_targets():
"ovr_config//cpu:x86_64": ["fht_avx.c"],
}),
exported_headers = ["fht.h"],
visibility = ["@EXECUTORCH_CLIENTS"],
visibility = ["PUBLIC"],
)

runtime.cxx_binary(
Expand Down
31 changes: 6 additions & 25 deletions extension/llm/custom_ops/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,7 @@ def define_common_targets():
"DEFAULT": [],
"ovr_config//cpu:arm64": ["-march=armv8.2-a+dotprod"],
}),
visibility = [
"//executorch/...",
"//executorch/extension/llm/custom_ops/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
# @lint-ignore BUCKLINT link_whole
link_whole = True,
force_static = True,
Expand All @@ -80,10 +76,7 @@ def define_common_targets():
],
headers = ["op_tile_crop.h"],
compiler_flags = ["-Wno-global-constructors"],
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
external_deps = [
"libtorch",
],
Expand All @@ -98,10 +91,7 @@ def define_common_targets():
srcs = [
"custom_ops.py",
],
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
deps = [
"//caffe2:torch",
],
Expand Down Expand Up @@ -141,10 +131,7 @@ def define_common_targets():
srcs = [
"preprocess_custom_ops.py",
],
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
deps = [
"//caffe2:torch",
],
Expand All @@ -155,10 +142,7 @@ def define_common_targets():
srcs = [
"model_sharding.py",
],
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
deps = [
"//caffe2:torch",
],
Expand All @@ -173,10 +157,7 @@ def define_common_targets():
"//executorch/extension/kernel_util:kernel_util",
],
compiler_flags = ["-Wno-missing-prototypes", "-Wno-global-constructors"],
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
# @lint-ignore BUCKLINT link_whole
link_whole = True,
force_static = True,
Expand Down
5 changes: 1 addition & 4 deletions extension/llm/export/config/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,5 @@ def define_common_targets():
],
_is_external_target = True,
base_module = "executorch.extension.llm.export.config",
visibility = [
"//executorch/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
)
4 changes: 1 addition & 3 deletions extension/llm/runner/io_manager/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,5 @@ def define_common_targets():
"//executorch/extension/tensor:tensor" + aten_suffix,
"//executorch/extension/module:module" + aten_suffix,
],
visibility = [
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
)
32 changes: 8 additions & 24 deletions extension/llm/runner/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,15 @@ def define_common_targets():
exported_headers = [
"irunner.h",
],
visibility = [
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
)

runtime.cxx_library(
name = "constants",
exported_headers = [
"constants.h",
],
visibility = [
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
)

for aten in get_aten_mode_options():
Expand All @@ -30,9 +26,7 @@ def define_common_targets():
"stats.h",
"util.h",
],
visibility = [
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
exported_deps = [
":constants",
"//executorch/extension/module:module" + aten_suffix,
Expand All @@ -44,9 +38,7 @@ def define_common_targets():
name = "text_decoder_runner" + aten_suffix,
exported_headers = ["text_decoder_runner.h"],
srcs = ["text_decoder_runner.cpp"],
visibility = [
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
exported_deps = [
":stats" + aten_suffix,
"//executorch/kernels/portable/cpu/util:arange_util" + aten_suffix,
Expand All @@ -61,9 +53,7 @@ def define_common_targets():
name = "text_prefiller" + aten_suffix,
exported_headers = ["text_prefiller.h"],
srcs = ["text_prefiller.cpp"],
visibility = [
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
exported_deps = [
":text_decoder_runner" + aten_suffix,
"//pytorch/tokenizers:headers",
Expand All @@ -75,9 +65,7 @@ def define_common_targets():
runtime.cxx_library(
name = "text_token_generator" + aten_suffix,
exported_headers = ["text_token_generator.h"],
visibility = [
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
exported_deps = [
":text_decoder_runner" + aten_suffix,
"//pytorch/tokenizers:headers",
Expand All @@ -89,9 +77,7 @@ def define_common_targets():
runtime.cxx_library(
name = "image_prefiller" + aten_suffix,
exported_headers = ["image_prefiller.h", "image.h"],
visibility = [
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
exported_deps = [
":constants",
"//executorch/extension/module:module" + aten_suffix,
Expand Down Expand Up @@ -134,9 +120,7 @@ def define_common_targets():
"llm_runner_helper.cpp",
"multimodal_runner.cpp",
],
visibility = [
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
compiler_flags = [
"-Wno-missing-prototypes",
],
Expand Down
4 changes: 1 addition & 3 deletions extension/llm/sampler/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@ def define_common_targets():
srcs = [
"sampler.cpp",
],
visibility = [
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
external_deps = [
"libtorch",
] if aten else [],
Expand Down
10 changes: 2 additions & 8 deletions extension/memory_allocator/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,7 @@ def define_common_targets():
exported_deps = [
"//executorch/runtime/core:memory_allocator",
],
visibility = [
"//executorch/extension/memory_allocator/test/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
)

runtime.cxx_library(
Expand All @@ -34,8 +31,5 @@ def define_common_targets():
exported_deps = [
"//executorch/runtime/core:memory_allocator",
],
visibility = [
"//executorch/extension/memory_allocator/test/...",
"@EXECUTORCH_CLIENTS",
],
visibility = ["PUBLIC"],
)
Loading
Loading