[ExecuTorch] FFHT: just expect benchmark to be installed #5288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vendored benchmark setup didn't work right for me out of the box, so I just changed the Makefile to use pkg-config to find benchmark wherever it is installed. Differential Revision: [D60194969](https://our.internmc.facebook.com/intern/diff/D60194969/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5288
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 33bfd62 with merge base 6328d41 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60194969 |
This was referenced Sep 11, 2024
kimishpatel
approved these changes
Sep 11, 2024
The vendored benchmark setup didn't work right for me out of the box, so I just changed the Makefile to use pkg-config to find benchmark wherever it is installed. Differential Revision: [D60194969](https://our.internmc.facebook.com/intern/diff/D60194969/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D60194969 |
The vendored benchmark setup didn't work right for me out of the box, so I just changed the Makefile to use pkg-config to find benchmark wherever it is installed. Differential Revision: [D60194969](https://our.internmc.facebook.com/intern/diff/D60194969/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D60194969 |
The vendored benchmark setup didn't work right for me out of the box, so I just changed the Makefile to use pkg-config to find benchmark wherever it is installed. Differential Revision: [D60194969](https://our.internmc.facebook.com/intern/diff/D60194969/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D60194969 |
|
This pull request has been merged in d3fb502. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#5288 The vendored benchmark setup didn't work right for me out of the box, so I just changed the Makefile to use pkg-config to find benchmark wherever it is installed. ghstack-source-id: 242230775 @exported-using-ghexport Differential Revision: [D60194969](https://our.internmc.facebook.com/intern/diff/D60194969/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The vendored benchmark setup didn't work right for me out of
the box, so I just changed the Makefile to use pkg-config to find
benchmark wherever it is installed.
Differential Revision: D60194969