[ExecuTorch] FFHT: ARM NEON port #5289
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch the code generator to be capable of generating NEON code and leave it configured to do that since we already have the checked-in generated AVX and SSE code. Generated code size was a potential issue so I also patched the generator to 1) reuse generated code for previous smaller sizes whereapplicable and 2) choose the smallest code that isn't more than 10% slower than the very fastest code. Differential Revision: [D60194970](https://our.internmc.facebook.com/intern/diff/D60194970/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5289
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bbf5ef4 with merge base 6328d41 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60194970 |
This was referenced Sep 11, 2024
kimishpatel
approved these changes
Sep 11, 2024
Patch the code generator to be capable of generating NEON code and leave it configured to do that since we already have the checked-in generated AVX and SSE code. Generated code size was a potential issue so I also patched the generator to 1) reuse generated code for previous smaller sizes whereapplicable and 2) choose the smallest code that isn't more than 10% slower than the very fastest code. Differential Revision: [D60194970](https://our.internmc.facebook.com/intern/diff/D60194970/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D60194970 |
Patch the code generator to be capable of generating NEON code and leave it configured to do that since we already have the checked-in generated AVX and SSE code. Generated code size was a potential issue so I also patched the generator to 1) reuse generated code for previous smaller sizes whereapplicable and 2) choose the smallest code that isn't more than 10% slower than the very fastest code. Differential Revision: [D60194970](https://our.internmc.facebook.com/intern/diff/D60194970/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D60194970 |
Patch the code generator to be capable of generating NEON code and leave it configured to do that since we already have the checked-in generated AVX and SSE code. Generated code size was a potential issue so I also patched the generator to 1) reuse generated code for previous smaller sizes whereapplicable and 2) choose the smallest code that isn't more than 10% slower than the very fastest code. Differential Revision: [D60194970](https://our.internmc.facebook.com/intern/diff/D60194970/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D60194970 |
|
This pull request has been merged in eedc38a. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#5289 Patch the code generator to be capable of generating NEON code and leave it configured to do that since we already have the checked-in generated AVX and SSE code. Generated code size was a potential issue so I also patched the generator to 1) reuse generated code for previous smaller sizes whereapplicable and 2) choose the smallest code that isn't more than 10% slower than the very fastest code. ghstack-source-id: 242230777 @exported-using-ghexport Differential Revision: [D60194970](https://our.internmc.facebook.com/intern/diff/D60194970/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Patch the code generator to be capable of generating NEON
code and leave it configured to do that since we already have the
checked-in generated AVX and SSE code. Generated code size was
a potential issue so I also patched the generator to 1) reuse
generated code for previous smaller sizes whereapplicable and 2)
choose the smallest code that isn't more than 10%
slower than the very fastest code.
Differential Revision: D60194970