Skip to content

Fix env in android perf so aar build #5330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix env in android perf so aar build #5330

wants to merge 3 commits into from

Conversation

kirklandsign
Copy link
Contributor

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 12, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5330

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 49a5442 with merge base b9ae0ec (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2024
@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

guangy10
guangy10 reviewed Sep 13, 2024
View reviewed changes
.github/workflows/android-perf.yml
export ANDROID_ABIS="arm64-v8a"
bash build/build_android_llm_demo.sh ${ARTIFACTS_DIR_NAME}
PYTHON_EXECUTABLE=python EXECUTORCH_BUILD_QNN=ON QNN_SDK_ROOT=/tmp/qnn/2.25.0.240728 bash build/build_android_llm_demo.sh ${ARTIFACTS_DIR_NAME}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't QNN_SDK_ROOT set already in setup-qnn-deps.sh? If it's overriding it to a different version, we must ensure that version is downloaded and configured correctly

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/pytorch/executorch/blob/main/.ci/scripts/build-qnn-sdk.sh#L14 fyi

@facebook-github-bot
Copy link
Contributor

@kirklandsign merged this pull request in c20ed5e.

@kirklandsign kirklandsign deleted the fix-android-perf-yml branch September 13, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guangy10 guangy10 guangy10 left review comments

@huydhn huydhn huydhn approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kirklandsign @facebook-github-bot @huydhn @guangy10