Skip to content

Fix env in android perf so aar build #5330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix env in android perf so aar build #5330

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da90367
Fix env in android perf so aar build
kirklandsign Sep 12, 2024
3495e0c
Update android-perf.yml
kirklandsign Sep 12, 2024
49a5442
Update android-perf.yml
kirklandsign Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/android-perf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,10 +229,9 @@ jobs:

PYTHON_EXECUTABLE=python bash .ci/scripts/setup-qnn-deps.sh
PYTHON_EXECUTABLE=python bash .ci/scripts/build-qnn-sdk.sh
export EXECUTORCH_BUILD_QNN=ON

export ANDROID_ABIS="arm64-v8a"
bash build/build_android_llm_demo.sh ${ARTIFACTS_DIR_NAME}
PYTHON_EXECUTABLE=python EXECUTORCH_BUILD_QNN=ON QNN_SDK_ROOT=/tmp/qnn/2.25.0.240728 bash build/build_android_llm_demo.sh ${ARTIFACTS_DIR_NAME}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't QNN_SDK_ROOT set already in setup-qnn-deps.sh? If it's overriding it to a different version, we must ensure that version is downloaded and configured correctly

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/pytorch/executorch/blob/main/.ci/scripts/build-qnn-sdk.sh#L14 fyi


# Upload artifacts to S3. The artifacts are needed not only by the device farm but also TorchChat
upload-android-apps:
Expand Down
Loading