Skip to content

Android upload artifact #5588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
+38 −3
Closed

Android upload artifact #5588

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6fdeb9c
Android try to upload release artifacts
kirklandsign Sep 24, 2024
ce0df6d
dryrun
kirklandsign Sep 24, 2024
4d9676b
Test
kirklandsign Sep 24, 2024
17ae807
Fix name
kirklandsign Sep 24, 2024
85981fc
Fix steps
kirklandsign Sep 24, 2024
64b3f0f
Fix date
kirklandsign Sep 24, 2024
71aa6cb
Nondry run
kirklandsign Sep 24, 2024
c569ea8
Fix AWS and ciflow tag
kirklandsign Sep 24, 2024
fbf66e3
Real build and upload sha256sums
kirklandsign Sep 24, 2024
e1167b0
more permissions
kirklandsign Sep 24, 2024
354b20f
Use a separate yml file
kirklandsign Sep 24, 2024
95328cd
Use workflow dispatch on a android/release tag for now
kirklandsign Sep 24, 2024
46f0114
add version_name
kirklandsign Sep 24, 2024
307a6e9
Add workflow version field
kirklandsign Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 38 additions & 3 deletions .github/workflows/android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,19 @@ on:
- extension/android/**
- extension/module/**
workflow_dispatch:
inputs:
version:
description: Version name to be uploaded for AAR release
required: false
type: string

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.event_name == 'workflow_dispatch' }}-${{ github.event_name == 'schedule' }}
cancel-in-progress: true

jobs:
build-llm-demo:
name: build-llm-demo
build-aar:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to refactor build-arr and upload-release-aar to a separate dispatchable workflow that:

  1. android.yml can call
  2. and we can manually dispatch it to build/upload Android release artifacts

However, that could come in a later PR if you prefer

name: build-aar
uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
with:
runner: linux.2xlarge
Expand All @@ -46,9 +51,39 @@ jobs:
# Build LLM Demo for Android
bash build/build_android_llm_demo.sh ${ARTIFACTS_DIR_NAME}

shasum -a 256 "${ARTIFACTS_DIR_NAME}/llm_demo/executorch.aar"

upload-release-aar:
name: upload-release-aar
needs: build-aar
if: ${{ startsWith(github.ref, 'refs/tags/android/release') }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note that if you use workflow_dispatch, you could run this step when the workflow event_type is workflow_dispatch. Let me find a concrete example

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it's ${{ github.event_name == 'workflow_dispatch' }}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Huy!

I am trying with #5606 for that path

runs-on: ubuntu-22.04
timeout-minutes: 10
permissions:
id-token: write
contents: read
steps:
- name: configure aws credentials
uses: aws-actions/[email protected]
with:
role-to-assume: arn:aws:iam::308535385114:role/gha_executorch_upload-frameworks-android
aws-region: us-east-1
- name: Upload AAR to RC if ciflow/android/release tag is present
shell: bash
run: |
wget https://gha-artifacts.s3.amazonaws.com/${{ github.repository }}/${{ github.run_id }}/artifacts/llm_demo/executorch.aar
shasum -a 256 executorch.aar > executorch.aar.sha256sums

pip install awscli==1.32.18
AWS_CMD="aws s3 cp"
VERSION="${{ inputs.version }}"
VERSION_NAME="${VERSION:-temp_snapshot}"
${AWS_CMD} executorch.aar s3://ossci-android/executorch/release/${VERSION_NAME}/executorch.aar --acl public-read
${AWS_CMD} executorch.aar.sha256sums s3://ossci-android/executorch/release/${VERSION_NAME}/executorch.aar.sha256sums --acl public-read

# Running Android emulator directly on the runner and not using Docker
run-emulator:
needs: build-llm-demo
needs: build-aar
# NB: Use metal install for KVM support to run the emulator faster
runs-on: linux.24xl.spr-metal
env:
Expand Down
Loading