Android upload artifact #5588
Android upload artifact #5588
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5588
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 307a6e9 with merge base 8660faf ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kirklandsign
added
ciflow/android/release
and removed
CLA Signed
|
Warning: Unknown label
Please add the new label to .github/pytorch-probot.yml |
facebook-github-bot
added
the
CLA Signed
.github/pytorch-probot.yml
Outdated
| # The schema is from https://github.com/pytorch/pytorch/blob/main/.github/pytorch-probot.yml | ||
| ciflow_push_tags: | ||
| - ciflow/android | ||
| - ciflow/android/release |
There was a problem hiding this comment.
I think it makes more sense to not use ciflow/android/release as it's a hack. The ciflow tag is for PR. If you want to keep the current implementation, you could name it something else I guess to avoid confusion, i.e. push/to/this/tag/to/release/android. Also, no need to include that here in the list of ciflow labels
| jobs: | ||
| build-llm-demo: | ||
| name: build-llm-demo | ||
| build-aar: |
There was a problem hiding this comment.
It's better to refactor build-arr and upload-release-aar to a separate dispatchable workflow that:
- android.yml can call
- and we can manually dispatch it to build/upload Android release artifacts
However, that could come in a later PR if you prefer
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| upload-release-aar: | ||
| name: upload-release-aar | ||
| needs: build-aar | ||
| if: ${{ startsWith(github.ref, 'refs/tags/android/release') }} |
There was a problem hiding this comment.
Just a note that if you use workflow_dispatch, you could run this step when the workflow event_type is workflow_dispatch. Let me find a concrete example
There was a problem hiding this comment.
Ah, it's ${{ github.event_name == 'workflow_dispatch' }}
There was a problem hiding this comment.
Thank you Huy!
I am trying with #5606 for that path
No description provided.