Android upload artifact #5588
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,8 +23,8 @@ concurrency: | |
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| build-aar: | ||
| name: build-aar | ||
| uses: pytorch/test-infra/.github/workflows/linux_job.yml@main | ||
| with: | ||
| runner: linux.2xlarge | ||
|
|
@@ -46,9 +46,38 @@ jobs: | |
| # Build LLM Demo for Android | ||
| bash build/build_android_llm_demo.sh ${ARTIFACTS_DIR_NAME} | ||
|
|
||
| shasum -a 256 "${ARTIFACTS_DIR_NAME}/llm_demo/executorch.aar" | ||
|
|
||
| upload-release-aar: | ||
| name: upload-release-aar | ||
| needs: build-aar | ||
| if: ${{ startsWith(github.ref, 'refs/tags/android/release') }} | ||
|
There was a problem hiding this comment. Just a note that if you use workflow_dispatch, you could run this step when the workflow event_type is workflow_dispatch. Let me find a concrete example There was a problem hiding this comment. Ah, it's There was a problem hiding this comment. Thank you Huy! I am trying with #5606 for that path |
||
| runs-on: ubuntu-22.04 | ||
| timeout-minutes: 10 | ||
| permissions: | ||
| id-token: write | ||
| contents: read | ||
| steps: | ||
| - name: configure aws credentials | ||
| uses: aws-actions/[email protected] | ||
| with: | ||
| role-to-assume: arn:aws:iam::308535385114:role/gha_executorch_upload-frameworks-android | ||
| aws-region: us-east-1 | ||
| - name: Upload AAR to RC if ciflow/android/release tag is present | ||
| shell: bash | ||
| run: | | ||
| wget https://gha-artifacts.s3.amazonaws.com/${{ github.repository }}/${{ github.run_id }}/artifacts/llm_demo/executorch.aar | ||
| shasum -a 256 executorch.aar > executorch.aar.sha256sums | ||
|
|
||
| pip install awscli==1.32.18 | ||
| AWS_CMD="aws s3 cp" | ||
| VERSION_NAME="$(date +'%Y%m%d')" | ||
| ${AWS_CMD} executorch.aar s3://ossci-android/executorch/release/${VERSION_NAME}/executorch.aar --acl public-read | ||
| ${AWS_CMD} executorch.aar.sha256sums s3://ossci-android/executorch/release/${VERSION_NAME}/executorch.aar.sha256sums --acl public-read | ||
|
|
||
| # Running Android emulator directly on the runner and not using Docker | ||
| run-emulator: | ||
| needs: build-aar | ||
| # NB: Use metal install for KVM support to run the emulator faster | ||
| runs-on: linux.24xl.spr-metal | ||
| env: | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to refactor
build-arrandupload-release-aarto a separate dispatchable workflow that:However, that could come in a later PR if you prefer