[ExecuTorch] generalize tests for unary_ufunc_realhb_to_floath ops (1/2) #5674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have 20-odd ops that just map a unary function over each element. We can share the test infrastructure rather than create a bunch of similar-looking tests. Note that I attempted to minimize the amount of code inside `IMPLEMENT_UNARY_UFUNC_REALHB_TO_FLOATH_TEST`; it is just a bunch of `TEST_F` calls that call into plain old C++ functions, so we haven't merely copied the tests into a macro. This diff only makes one op adopt the test to prove it works; following diff(s) will roll out fully. Differential Revision: [D63431290](https://our.internmc.facebook.com/intern/diff/D63431290/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5674
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 91c7f43 with merge base 944bd67 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63431290 |
…r unary_ufunc_realhb_to_floath ops (1/2)" We have 20-odd ops that just map a unary function over each element. We can share the test infrastructure rather than create a bunch of similar-looking tests. Note that I attempted to minimize the amount of code inside `IMPLEMENT_UNARY_UFUNC_REALHB_TO_FLOATH_TEST`; it is just a bunch of `TEST_F` calls that call into plain old C++ functions, so we haven't merely copied the tests into a macro. This diff only makes one op adopt the test to prove it works; following diff(s) will roll out fully. Differential Revision: [D63431290](https://our.internmc.facebook.com/intern/diff/D63431290/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63431290 |
…nc_realhb_to_floath ops (1/2)" We have 20-odd ops that just map a unary function over each element. We can share the test infrastructure rather than create a bunch of similar-looking tests. Note that I attempted to minimize the amount of code inside `IMPLEMENT_UNARY_UFUNC_REALHB_TO_FLOATH_TEST`; it is just a bunch of `TEST_F` calls that call into plain old C++ functions, so we haven't merely copied the tests into a macro. This diff only makes one op adopt the test to prove it works; following diff(s) will roll out fully. Differential Revision: [D63431290](https://our.internmc.facebook.com/intern/diff/D63431290/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63431290 |
This was referenced Sep 26, 2024
…oath ops (1/2)" We have 20-odd ops that just map a unary function over each element. We can share the test infrastructure rather than create a bunch of similar-looking tests. Note that I attempted to minimize the amount of code inside `IMPLEMENT_UNARY_UFUNC_REALHB_TO_FLOATH_TEST`; it is just a bunch of `TEST_F` calls that call into plain old C++ functions, so we haven't merely copied the tests into a macro. This diff only makes one op adopt the test to prove it works; following diff(s) will roll out fully. Differential Revision: [D63431290](https://our.internmc.facebook.com/intern/diff/D63431290/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63431290 |
swolchok
added a commit
that referenced
this pull request
Sep 26, 2024
Pull Request resolved: #5674 We have 20-odd ops that just map a unary function over each element. We can share the test infrastructure rather than create a bunch of similar-looking tests. Note that I attempted to minimize the amount of code inside `IMPLEMENT_UNARY_UFUNC_REALHB_TO_FLOATH_TEST`; it is just a bunch of `TEST_F` calls that call into plain old C++ functions, so we haven't merely copied the tests into a macro. This diff only makes one op adopt the test to prove it works; following diff(s) will roll out fully. ghstack-source-id: 244860513 @exported-using-ghexport Differential Revision: [D63431290](https://our.internmc.facebook.com/intern/diff/D63431290/)
…oath ops (1/2)" We have 20-odd ops that just map a unary function over each element. We can share the test infrastructure rather than create a bunch of similar-looking tests. Note that I attempted to minimize the amount of code inside `IMPLEMENT_UNARY_UFUNC_REALHB_TO_FLOATH_TEST`; it is just a bunch of `TEST_F` calls that call into plain old C++ functions, so we haven't merely copied the tests into a macro. This diff only makes one op adopt the test to prove it works; following diff(s) will roll out fully. Differential Revision: [D63431290](https://our.internmc.facebook.com/intern/diff/D63431290/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63431290 |
…oath ops (1/2)" We have 20-odd ops that just map a unary function over each element. We can share the test infrastructure rather than create a bunch of similar-looking tests. Note that I attempted to minimize the amount of code inside `IMPLEMENT_UNARY_UFUNC_REALHB_TO_FLOATH_TEST`; it is just a bunch of `TEST_F` calls that call into plain old C++ functions, so we haven't merely copied the tests into a macro. This diff only makes one op adopt the test to prove it works; following diff(s) will roll out fully. Differential Revision: [D63431290](https://our.internmc.facebook.com/intern/diff/D63431290/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63431290 |
…oath ops (1/2)" We have 20-odd ops that just map a unary function over each element. We can share the test infrastructure rather than create a bunch of similar-looking tests. Note that I attempted to minimize the amount of code inside `IMPLEMENT_UNARY_UFUNC_REALHB_TO_FLOATH_TEST`; it is just a bunch of `TEST_F` calls that call into plain old C++ functions, so we haven't merely copied the tests into a macro. This diff only makes one op adopt the test to prove it works; following diff(s) will roll out fully. Differential Revision: [D63431290](https://our.internmc.facebook.com/intern/diff/D63431290/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63431290 |
…oath ops (1/2)" We have 20-odd ops that just map a unary function over each element. We can share the test infrastructure rather than create a bunch of similar-looking tests. Note that I attempted to minimize the amount of code inside `IMPLEMENT_UNARY_UFUNC_REALHB_TO_FLOATH_TEST`; it is just a bunch of `TEST_F` calls that call into plain old C++ functions, so we haven't merely copied the tests into a macro. This diff only makes one op adopt the test to prove it works; following diff(s) will roll out fully. Differential Revision: [D63431290](https://our.internmc.facebook.com/intern/diff/D63431290/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63431290 |
…oath ops (1/2)" We have 20-odd ops that just map a unary function over each element. We can share the test infrastructure rather than create a bunch of similar-looking tests. Note that I attempted to minimize the amount of code inside `IMPLEMENT_UNARY_UFUNC_REALHB_TO_FLOATH_TEST`; it is just a bunch of `TEST_F` calls that call into plain old C++ functions, so we haven't merely copied the tests into a macro. This diff only makes one op adopt the test to prove it works; following diff(s) will roll out fully. Differential Revision: [D63431290](https://our.internmc.facebook.com/intern/diff/D63431290/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63431290 |
…oath ops (1/2)" We have 20-odd ops that just map a unary function over each element. We can share the test infrastructure rather than create a bunch of similar-looking tests. Note that I attempted to minimize the amount of code inside `IMPLEMENT_UNARY_UFUNC_REALHB_TO_FLOATH_TEST`; it is just a bunch of `TEST_F` calls that call into plain old C++ functions, so we haven't merely copied the tests into a macro. This diff only makes one op adopt the test to prove it works; following diff(s) will roll out fully. Differential Revision: [D63431290](https://our.internmc.facebook.com/intern/diff/D63431290/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63431290 |
manuelcandales
approved these changes
Sep 30, 2024
Contributor
|
This pull request has been merged in 829ba3e. |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#5674 We have 20-odd ops that just map a unary function over each element. We can share the test infrastructure rather than create a bunch of similar-looking tests. Note that I attempted to minimize the amount of code inside `IMPLEMENT_UNARY_UFUNC_REALHB_TO_FLOATH_TEST`; it is just a bunch of `TEST_F` calls that call into plain old C++ functions, so we haven't merely copied the tests into a macro. This diff only makes one op adopt the test to prove it works; following diff(s) will roll out fully. ghstack-source-id: 245555539 @exported-using-ghexport Differential Revision: [D63431290](https://our.internmc.facebook.com/intern/diff/D63431290/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
We have 20-odd ops that just map a unary function over each
element. We can share the test infrastructure rather than create a
bunch of similar-looking tests. Note that I attempted to minimize the
amount of code inside
IMPLEMENT_UNARY_UFUNC_REALHB_TO_FLOATH_TEST;it is just a bunch of
TEST_Fcalls that call into plain old C++functions, so we haven't merely copied the tests into a macro.
This diff only makes one op adopt the test to prove it works; following diff(s) will roll out fully.
Differential Revision: D63431290