[ExecuTorch] migrate all unary_ufunc_realhb_to_floath op tests to general infra (2/2) #5675
+280
−2,317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eral infra (2/2) Follow up on previous diff by migrating all the tests. Most migrations were straightforward where ops just had the same test repeated; some of them had worse tests, some of them had different-but-equivalent tests that incorrectly skipped dynamic shape. No actual bugs found, which makes sense since the implementations are shared. Differential Revision: [D63431291](https://our.internmc.facebook.com/intern/diff/D63431291/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5675
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 74aa378 with merge base 944bd67 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63431291 |
swolchok
added a commit
that referenced
this pull request
Sep 26, 2024
…eral infra (2/2) Follow up on previous diff by migrating all the tests. Most migrations were straightforward where ops just had the same test repeated; some of them had worse tests, some of them had different-but-equivalent tests that incorrectly skipped dynamic shape. No actual bugs found, which makes sense since the implementations are shared. Differential Revision: [D63431291](https://our.internmc.facebook.com/intern/diff/D63431291/) ghstack-source-id: 244762687 Pull Request resolved: #5675
…func_realhb_to_floath op tests to general infra (2/2)" Follow up on previous diff by migrating all the tests. Most migrations were straightforward where ops just had the same test repeated; some of them had worse tests, some of them had different-but-equivalent tests that incorrectly skipped dynamic shape. No actual bugs found, which makes sense since the implementations are shared. Differential Revision: [D63431291](https://our.internmc.facebook.com/intern/diff/D63431291/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63431291 |
swolchok
added a commit
that referenced
this pull request
Sep 26, 2024
…eral infra (2/2) Pull Request resolved: #5675 Follow up on previous diff by migrating all the tests. Most migrations were straightforward where ops just had the same test repeated; some of them had worse tests, some of them had different-but-equivalent tests that incorrectly skipped dynamic shape. No actual bugs found, which makes sense since the implementations are shared. Differential Revision: [D63431291](https://our.internmc.facebook.com/intern/diff/D63431291/) ghstack-source-id: 244771366
…_to_floath op tests to general infra (2/2)" Follow up on previous diff by migrating all the tests. Most migrations were straightforward where ops just had the same test repeated; some of them had worse tests, some of them had different-but-equivalent tests that incorrectly skipped dynamic shape. No actual bugs found, which makes sense since the implementations are shared. Differential Revision: [D63431291](https://our.internmc.facebook.com/intern/diff/D63431291/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63431291 |
This was referenced Sep 26, 2024
…ests to general infra (2/2)" Follow up on previous diff by migrating all the tests. Most migrations were straightforward where ops just had the same test repeated; some of them had worse tests, some of them had different-but-equivalent tests that incorrectly skipped dynamic shape. No actual bugs found, which makes sense since the implementations are shared. Differential Revision: [D63431291](https://our.internmc.facebook.com/intern/diff/D63431291/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63431291 |
…ests to general infra (2/2)" Follow up on previous diff by migrating all the tests. Most migrations were straightforward where ops just had the same test repeated; some of them had worse tests, some of them had different-but-equivalent tests that incorrectly skipped dynamic shape. No actual bugs found, which makes sense since the implementations are shared. Differential Revision: [D63431291](https://our.internmc.facebook.com/intern/diff/D63431291/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63431291 |
…ests to general infra (2/2)" Follow up on previous diff by migrating all the tests. Most migrations were straightforward where ops just had the same test repeated; some of them had worse tests, some of them had different-but-equivalent tests that incorrectly skipped dynamic shape. No actual bugs found, which makes sense since the implementations are shared. Differential Revision: [D63431291](https://our.internmc.facebook.com/intern/diff/D63431291/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63431291 |
…ests to general infra (2/2)" Follow up on previous diff by migrating all the tests. Most migrations were straightforward where ops just had the same test repeated; some of them had worse tests, some of them had different-but-equivalent tests that incorrectly skipped dynamic shape. No actual bugs found, which makes sense since the implementations are shared. Differential Revision: [D63431291](https://our.internmc.facebook.com/intern/diff/D63431291/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63431291 |
…ests to general infra (2/2)" Follow up on previous diff by migrating all the tests. Most migrations were straightforward where ops just had the same test repeated; some of them had worse tests, some of them had different-but-equivalent tests that incorrectly skipped dynamic shape. No actual bugs found, which makes sense since the implementations are shared. Differential Revision: [D63431291](https://our.internmc.facebook.com/intern/diff/D63431291/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63431291 |
…ests to general infra (2/2)" Follow up on previous diff by migrating all the tests. Most migrations were straightforward where ops just had the same test repeated; some of them had worse tests, some of them had different-but-equivalent tests that incorrectly skipped dynamic shape. No actual bugs found, which makes sense since the implementations are shared. Differential Revision: [D63431291](https://our.internmc.facebook.com/intern/diff/D63431291/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63431291 |
…ests to general infra (2/2)" Follow up on previous diff by migrating all the tests. Most migrations were straightforward where ops just had the same test repeated; some of them had worse tests, some of them had different-but-equivalent tests that incorrectly skipped dynamic shape. No actual bugs found, which makes sense since the implementations are shared. Differential Revision: [D63431291](https://our.internmc.facebook.com/intern/diff/D63431291/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63431291 |
manuelcandales
approved these changes
Sep 30, 2024
…all unary_ufunc_realhb_to_floath op tests to general infra (2/2)" Follow up on previous diff by migrating all the tests. Most migrations were straightforward where ops just had the same test repeated; some of them had worse tests, some of them had different-but-equivalent tests that incorrectly skipped dynamic shape. No actual bugs found, which makes sense since the implementations are shared. Differential Revision: [D63431291](https://our.internmc.facebook.com/intern/diff/D63431291/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63431291 |
swolchok
added a commit
that referenced
this pull request
Oct 1, 2024
…eral infra (2/2) Pull Request resolved: #5675 Follow up on previous diff by migrating all the tests. Most migrations were straightforward where ops just had the same test repeated; some of them had worse tests, some of them had different-but-equivalent tests that incorrectly skipped dynamic shape. No actual bugs found, which makes sense since the implementations are shared. ghstack-source-id: 245577588 Differential Revision: [D63431291](https://our.internmc.facebook.com/intern/diff/D63431291/)
Contributor
|
This pull request has been merged in b63c68e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Follow up on previous diff by migrating all the tests. Most migrations were straightforward where ops just had the same test repeated; some of them had worse tests, some of them had different-but-equivalent tests that incorrectly skipped dynamic shape. No actual bugs found, which makes sense since the implementations are shared.
Differential Revision: D63431291