Add support for upsample_nearest2d op in the Arm backend #5746

Tessil · 2024-09-30T14:59:42Z

Add support for the torch.ops.aten.upsample_nearest2d.vec operator in the Arm backend.

The torch.ops.aten.upsample_nearest2d.vec operator is added to the operators to not decompose so that it can directly be legalized to a tosa.resize operator.

Change-Id: Id0b742214e5432957b2f573b4218f09a4d9734e4

pytorch-bot · 2024-09-30T14:59:46Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5746

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8894f23 with merge base 995c2bf ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Tessil · 2024-09-30T15:21:13Z

@pytorchbot label ciflow/trunk

pytorch-bot · 2024-09-30T15:21:18Z

Can't add following labels to PR: ciflow/trunk. Please ping one of the reviewers for help.

pytorch-bot · 2024-09-30T16:59:58Z

Please seek CI approval before scheduling CIFlow labels

digantdesai · 2024-09-30T17:28:13Z

backends/arm/test/ops/test_upsample_nearest2d.py

+
+
+test_data_suite = [
+    # (test_name, test_data, size, scale_factor, compare_outputs)


❤️ these test. Awesome!

backends/arm/test/tester/arm_tester.py

digantdesai · 2024-09-30T17:33:34Z

Please rebase?

facebook-github-bot · 2024-09-30T17:33:36Z

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Tessil · 2024-10-04T14:32:46Z

Thanks for the review. I rebased the change and fixed the conflicts.

facebook-github-bot · 2024-10-08T15:45:28Z

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

digantdesai · 2024-10-08T22:14:31Z

Internal checker found these type issues, can you please fix and rebase? Thanks.

Found type errors!
executorch/backends/arm/tosa_utils.py:356:16 Undefined or invalid type [11]: Annotation `torch.tensor` is not defined as a type.
executorch/backends/arm/tosa_utils.py:373:21 Incompatible parameter type [6]: In call `torch._C._VariableFunctions.all`, for 1st positional argument, expected `Tensor` but got `bool`.
executorch/backends/arm/tosa_utils.py:374:21 Incompatible parameter type [6]: In call `torch._C._VariableFunctions.all`, for 1st positional argument, expected `Tensor` but got `bool`.

Tessil · 2024-10-09T15:05:53Z

Thanks, the last change should fix this.

facebook-github-bot · 2024-10-09T15:24:55Z

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

digantdesai · 2024-10-15T20:54:51Z

still seems like a type errors on op_upsample_nearest2d.py:48 get_resize_parameters for 3rd arg expected ResizeMode but got int. Sorry for the delay.

facebook-github-bot · 2024-10-15T20:56:18Z

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

digantdesai · 2024-10-16T15:08:32Z

Also rebase?

Tessil · 2024-10-17T09:12:17Z

Thanks, I rebased and fixed the issue.

facebook-github-bot · 2024-10-21T14:33:47Z

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2024-10-22T01:24:35Z

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

digantdesai · 2024-10-22T15:16:30Z

Sorry rebase?

Tessil · 2024-10-23T15:01:34Z

@digantdesai Thanks, done

facebook-github-bot · 2024-10-24T15:29:08Z

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

digantdesai · 2024-10-28T16:12:32Z

If CI is not green, please make it a Draft PR

Tessil · 2024-10-28T17:43:53Z

The failure doesn't seem to be related to this PR as it's the new test_var.py tests introduced during the rebase from upstream that are failing. I'll check internally if these can be fixed in another PR.

facebook-github-bot · 2024-11-05T15:33:51Z

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

digantdesai · 2024-11-05T16:32:47Z

Rebase please?

freddan80 · 2024-11-07T07:01:24Z

Pls fix the failing unit test.

Tessil · 2024-11-08T16:39:28Z

The unit test failure is not due to the code of this PR, we confirmed it internally. We should check to raise another PR to fix the torch.var test failure as it's not directly related to this one.

freddan80 · 2024-11-09T08:16:56Z

Rebase please

Change-Id: Id0b742214e5432957b2f573b4218f09a4d9734e4

Tessil · 2024-11-12T14:45:07Z

With 995c2bf fixing the test_var accuracy issue, the tests are now passing.

freddan80 · 2024-11-12T16:00:28Z

@digantdesai I'm blocked from merging dues to
"Meta Internal-Only Changes Check: This Pull Request has changes that have not been imported to the Diff, please import the Pull Request"

Do you mind helping out?

facebook-github-bot · 2024-11-12T16:04:35Z

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

digantdesai · 2024-11-12T21:18:35Z

Sigh, sorry can you please rebase?

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 30, 2024

pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Sep 30, 2024

mergennachin added the ciflow/trunk label Sep 30, 2024

pytorch-bot bot removed the ciflow/trunk label Sep 30, 2024

digantdesai approved these changes Sep 30, 2024

View reviewed changes

Tessil force-pushed the toupstream/upsample_nearest2d branch from baf427b to 5c042d3 Compare October 4, 2024 14:30

Tessil added the ciflow/trunk label Oct 4, 2024

Tessil force-pushed the toupstream/upsample_nearest2d branch from 5c042d3 to 8f769fe Compare October 8, 2024 09:27

Tessil force-pushed the toupstream/upsample_nearest2d branch from 8f769fe to cf7310c Compare October 9, 2024 14:53

Tessil force-pushed the toupstream/upsample_nearest2d branch from cf7310c to 533d9db Compare October 17, 2024 09:11

Tessil force-pushed the toupstream/upsample_nearest2d branch from 8eea28f to 675d0ac Compare October 23, 2024 15:00

Tessil added ciflow/trunk and removed ciflow/trunk labels Oct 31, 2024

Tessil force-pushed the toupstream/upsample_nearest2d branch from 675d0ac to 4fb9443 Compare November 6, 2024 09:19

Tessil added ciflow/trunk and removed ciflow/trunk labels Nov 6, 2024

Tessil force-pushed the toupstream/upsample_nearest2d branch 2 times, most recently from 4f362f2 to 19622cd Compare November 12, 2024 10:44

Add support for upsample_nearest2d op in the Arm backend

8894f23

Change-Id: Id0b742214e5432957b2f573b4218f09a4d9734e4

Tessil force-pushed the toupstream/upsample_nearest2d branch from 19622cd to 8894f23 Compare November 12, 2024 13:49

freddan80 approved these changes Nov 12, 2024

View reviewed changes

freddan80 merged commit 4c68660 into pytorch:main Nov 13, 2024
101 of 102 checks passed



		test_data_suite = [
		# (test_name, test_data, size, scale_factor, compare_outputs)

Add support for upsample_nearest2d op in the Arm backend #5746

Add support for upsample_nearest2d op in the Arm backend #5746

Uh oh!

Conversation

Tessil commented Sep 30, 2024

Uh oh!

pytorch-bot bot commented Sep 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5746

✅ No Failures

Uh oh!

Tessil commented Sep 30, 2024

Uh oh!

pytorch-bot bot commented Sep 30, 2024

Uh oh!

pytorch-bot bot commented Sep 30, 2024

Uh oh!

digantdesai Sep 30, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

digantdesai commented Sep 30, 2024

Uh oh!

facebook-github-bot commented Sep 30, 2024

Uh oh!

Tessil commented Oct 4, 2024

Uh oh!

facebook-github-bot commented Oct 8, 2024

Uh oh!

digantdesai commented Oct 8, 2024

Uh oh!

Tessil commented Oct 9, 2024

Uh oh!

facebook-github-bot commented Oct 9, 2024

Uh oh!

digantdesai commented Oct 15, 2024

Uh oh!

facebook-github-bot commented Oct 15, 2024

Uh oh!

digantdesai commented Oct 16, 2024

Uh oh!

Tessil commented Oct 17, 2024

Uh oh!

facebook-github-bot commented Oct 21, 2024

Uh oh!

facebook-github-bot commented Oct 22, 2024

Uh oh!

digantdesai commented Oct 22, 2024

Uh oh!

Tessil commented Oct 23, 2024

Uh oh!

facebook-github-bot commented Oct 24, 2024

Uh oh!

digantdesai commented Oct 28, 2024

Uh oh!

Tessil commented Oct 28, 2024

Uh oh!

facebook-github-bot commented Nov 5, 2024

Uh oh!

digantdesai commented Nov 5, 2024

Uh oh!

freddan80 commented Nov 7, 2024

Uh oh!

Tessil commented Nov 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

freddan80 commented Nov 9, 2024

Uh oh!

Tessil commented Nov 12, 2024

Uh oh!

freddan80 commented Nov 12, 2024

Uh oh!

facebook-github-bot commented Nov 12, 2024

Uh oh!

digantdesai commented Nov 12, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

pytorch-bot bot commented Sep 30, 2024 •

edited

Loading

Tessil commented Nov 8, 2024 •

edited

Loading