Exclude log_outputs() from execute profiling scope #6325
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6325
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 12cdd75 with merge base 6b858f2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64541740 |
mcremon-meta
approved these changes
Oct 17, 2024
Contributor
mcremon-meta
left a comment
mcremon-meta
left a comment
There was a problem hiding this comment.
LGTM when linting is good! Thanks :)
Summary: `log_outputs()` should not be included in the `execute()` profiling scope as it distorts the profiling numbers especially on smaller embedded platforms like Xtensa. Reviewed By: mcremon-meta Differential Revision: D64541740
facebook-github-bot
force-pushed
the
export-D64541740
branch
from
3c2b65b to
12cdd75
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64541740 |
Contributor
|
This pull request has been merged in 8d6d18a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
log_outputs()should not be included in theexecute()profiling scope as it distorts the profiling numbers especially on smaller embedded platforms like Xtensa.Differential Revision: D64541740