Skip to content

Exclude log_outputs() from execute profiling scope #6325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Exclude log_outputs() from execute profiling scope #6325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions runtime/executor/method.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1191,8 +1191,9 @@ Error Method::step() {
static_cast<int32_t>(step_state_.chain_idx),
static_cast<uint32_t>(step_state_.instr_idx));
EXECUTORCH_SCOPE_PROF("Method::step");
internal::EventTracerProfileMethodScope event_tracer_profile_scope =
internal::EventTracerProfileMethodScope(event_tracer_, "Method::step");
EventTracerEntry event_tracer_entry =
internal::event_tracer_begin_profiling_event(
event_tracer_, "Method::step");
ET_CHECK_OR_RETURN_ERROR(
initialized(),
InvalidState,
Expand All @@ -1218,6 +1219,7 @@ Error Method::step() {
return status;
}

internal::event_tracer_end_profiling_event(event_tracer_, event_tracer_entry);
// end of the current chain, advance to the next chain
if (step_state_.instr_idx == num_instructions) {
step_state_.instr_idx = 0;
Expand All @@ -1233,8 +1235,9 @@ Error Method::experimental_step() {

Error Method::execute() {
internal::event_tracer_create_event_block(event_tracer_, "Execute");
internal::EventTracerProfileMethodScope event_tracer_profile_scope =
internal::EventTracerProfileMethodScope(event_tracer_, "Method::execute");
EventTracerEntry event_tracer_entry =
internal::event_tracer_begin_profiling_event(
event_tracer_, "Method::execute");
EXECUTORCH_SCOPE_PROF("Method::execute");
ET_CHECK_OR_RETURN_ERROR(
initialized(),
Expand Down Expand Up @@ -1270,7 +1273,7 @@ Error Method::execute() {
}
}
}

internal::event_tracer_end_profiling_event(event_tracer_, event_tracer_entry);
log_outputs();

// TODO(jakeszwe, dbort): Decide on calling execute back to back without
Expand Down
Loading