Core runtime changes for Windows MSVC support #6624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6624
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit c2645d7 with merge base 8a4e492 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65328601 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 3, 2024
Summary: Pull Request resolved: #6624 Differential Revision: D65328601
facebook-github-bot
force-pushed
the
export-D65328601
branch
from
f0a52f4 to
1e7d378
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65328601 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 3, 2024
Summary: Miscellaneous core runtime fixes to make sure we can build with MSVC. Differential Revision: D65328601
facebook-github-bot
force-pushed
the
export-D65328601
branch
from
1e7d378 to
27dd090
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65328601 |
tarun292
force-pushed
the
export-D65328601
branch
from
27dd090 to
45c3585
Compare
tarun292
added a commit
that referenced
this pull request
Nov 4, 2024
Summary: Miscellaneous core runtime fixes to make sure we can build with MSVC. Differential Revision: D65328601
|
This pull request was exported from Phabricator. Differential Revision: D65328601 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
Summary: Miscellaneous core runtime fixes to make sure we can build with MSVC. Differential Revision: D65328601
facebook-github-bot
force-pushed
the
export-D65328601
branch
from
45c3585 to
c1b8d44
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65328601 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
Summary: Miscellaneous core runtime fixes to make sure we can build with MSVC. Differential Revision: D65328601
facebook-github-bot
force-pushed
the
export-D65328601
branch
from
c1b8d44 to
5e29b6d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65328601 |
tarun292
added a commit
that referenced
this pull request
Nov 4, 2024
Summary: Miscellaneous core runtime fixes to make sure we can build with MSVC. Differential Revision: D65328601
tarun292
added a commit
that referenced
this pull request
Nov 4, 2024
Summary: Miscellaneous core runtime fixes to make sure we can build with MSVC. Differential Revision: D65328601
tarun292
force-pushed
the
export-D65328601
branch
from
5e29b6d to
1820d3b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65328601 |
tarun292
added a commit
that referenced
this pull request
Nov 4, 2024
Summary: Miscellaneous core runtime fixes to make sure we can build with MSVC. Differential Revision: D65328601
tarun292
force-pushed
the
export-D65328601
branch
from
1820d3b to
1c559de
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65328601 |
tarun292
added a commit
that referenced
this pull request
Nov 4, 2024
Summary: Miscellaneous core runtime fixes to make sure we can build with MSVC. Differential Revision: D65328601
tarun292
added a commit
that referenced
this pull request
Nov 4, 2024
Summary: Miscellaneous core runtime fixes to make sure we can build with MSVC. Differential Revision: D65328601
tarun292
added a commit
that referenced
this pull request
Nov 4, 2024
Summary: Miscellaneous core runtime fixes to make sure we can build with MSVC. Differential Revision: D65328601
tarun292
force-pushed
the
export-D65328601
branch
from
1c559de to
619438c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65328601 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
Summary: Miscellaneous core runtime fixes to make sure we can build with MSVC. Differential Revision: D65328601
facebook-github-bot
force-pushed
the
export-D65328601
branch
from
619438c to
1e831fb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65328601 |
dbort
approved these changes
Nov 5, 2024
tarun292
added a commit
that referenced
this pull request
Nov 5, 2024
Summary: Miscellaneous core runtime fixes to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328601
tarun292
force-pushed
the
export-D65328601
branch
from
1e831fb to
9f78850
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65328601 |
tarun292
added a commit
that referenced
this pull request
Nov 5, 2024
Summary: Miscellaneous core runtime fixes to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328601
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
Summary: Miscellaneous core runtime fixes to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328601
facebook-github-bot
force-pushed
the
export-D65328601
branch
from
9f78850 to
0091d19
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65328601 |
Summary: Miscellaneous core runtime fixes to make sure we can build with MSVC. Reviewed By: dbort Differential Revision: D65328601
facebook-github-bot
force-pushed
the
export-D65328601
branch
from
0091d19 to
c2645d7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65328601 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D65328601