Skip to content

Conversation

@freddan80
Copy link
Collaborator

Reverts #7160

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7198

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit 1371dbb with merge base cd306d3 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 5, 2024
@freddan80 freddan80 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Dec 5, 2024
@digantdesai
Copy link
Contributor

Ok so this takes us back to #7123?

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't remember how many tests were failing when Zingo described it, glad to see only one :)

) # Works

@parameterized.expand(testsuite_conv2d, skip_on_empty=True)
@unittest.expectedFailure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you comment why or a TODO(#TASK)? 🙏

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zingo ^^^

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit in a flux, both we and vela have not yet limited delegation to only support what the hardware, vela team adds/change some support/check now and then under regor development so it changes little per version. We currently handle this with skip/expected fail and have an internal task to clean it up when regor is more stable an we also have our config system in place.

@freddan80 freddan80 merged commit e013e53 into main Dec 5, 2024
108 of 110 checks passed
@freddan80 freddan80 deleted the revert-7160-Arm-backend-Back-Ethos-U-Vela-compiler-to-working-version branch December 5, 2024 18:16
@zingo
Copy link
Collaborator

zingo commented Dec 6, 2024

I tried to diff the two version of vela to see what could cause the CI to break so we can more easy avoid this in the future. Unfortunately I could not find anything suspicious. All changes that was not in source files seem to not touch any version or dependency what I could detect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants