-
Notifications
You must be signed in to change notification settings - Fork 706
Revert "Arm backend : Back Ethos-U Vela compiler to working version" #7198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Arm backend : Back Ethos-U Vela compiler to working version" #7198
Conversation
This reverts commit 22a75be.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7198
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled JobAs of commit 1371dbb with merge base cd306d3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Ok so this takes us back to #7123? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I don't remember how many tests were failing when Zingo described it, glad to see only one :)
| ) # Works | ||
|
|
||
| @parameterized.expand(testsuite_conv2d, skip_on_empty=True) | ||
| @unittest.expectedFailure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you comment why or a TODO(#TASK)? 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zingo ^^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit in a flux, both we and vela have not yet limited delegation to only support what the hardware, vela team adds/change some support/check now and then under regor development so it changes little per version. We currently handle this with skip/expected fail and have an internal task to clean it up when regor is more stable an we also have our config system in place.
|
I tried to diff the two version of vela to see what could cause the CI to break so we can more easy avoid this in the future. Unfortunately I could not find anything suspicious. All changes that was not in source files seem to not touch any version or dependency what I could detect. |
Reverts #7160