Skip to content

Revert "Arm backend : Back Ethos-U Vela compiler to working version" #7198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Revert "Arm backend : Back Ethos-U Vela compiler to working version" #7198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backends/arm/test/ops/test_depthwise_conv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ def test_dw_conv_tosa_BI(self, test_name: str, model: torch.nn.Module):
) # Works

@parameterized.expand(testsuite_conv2d, skip_on_empty=True)
@unittest.expectedFailure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you comment why or a TODO(#TASK)? 🙏

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zingo ^^^

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit in a flux, both we and vela have not yet limited delegation to only support what the hardware, vela team adds/change some support/check now and then under regor development so it changes little per version. We currently handle this with skip/expected fail and have an internal task to clean it up when regor is more stable an we also have our config system in place.

def test_dw_conv2d_u55_BI(
self, test_name: str, model: torch.nn.Module, set_quantize_io: bool = False
):
Expand Down
4 changes: 2 additions & 2 deletions examples/arm/aot_arm_compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ def get_compile_spec(
target,
system_config="Ethos_U55_High_End_Embedded",
memory_mode="Shared_Sram",
extra_flags="--debug-force-regor --output-format=raw",
extra_flags="--debug-force-regor --output-format=raw --verbose-operators --verbose-cycle-estimate",
)
.set_permute_memory_format(True)
.set_quantize_io(True)
Expand All @@ -286,7 +286,7 @@ def get_compile_spec(
target,
system_config="Ethos_U85_SYS_DRAM_Mid",
memory_mode="Shared_Sram",
extra_flags="--output-format=raw",
extra_flags="--output-format=raw --verbose-operators --verbose-cycle-estimate",
)
.set_permute_memory_format(True)
.set_quantize_io(True)
Expand Down
2 changes: 1 addition & 1 deletion examples/arm/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ tosa_reference_model_rev="f9ea4ab7da19318fe36b1c34d68a3e40fd6e56c5"

# vela
vela_repo_url="https://review.mlplatform.org/ml/ethos-u/ethos-u-vela"
vela_rev="49d0ae16bafd1db0fcb6790f12b7f249acf1974d"
vela_rev="a08fc18780827b5fefc814dd0162ee6317ce0ae7"

########
### Mandatory user args
Expand Down
Loading