Skip to content

Support Half/BFloat16 in runner_util/inputs_portable #7750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 23, 2025
Merged

Support Half/BFloat16 in runner_util/inputs_portable #7750

merged 3 commits into from
Jan 23, 2025

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Jan 17, 2025

Partial fix for #7748.

@swolchok
Update
df3ce0d 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jan 17, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 17, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7750

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 7c6ecd6 with merge base 4bc2029 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Jan 17, 2025
@swolchok
Support Half/BFloat16 in runner_util/inputs_portable
d47abd4 
Partial fix for #7748.

ghstack-source-id: 0c7e0a5
ghstack-comment-id: 2599375147
Pull Request resolved: #7750
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 17, 2025
@swolchok swolchok mentioned this pull request Jan 17, 2025
Closed
@swolchok swolchok requested a review from dbort January 17, 2025 23:53
@swolchok swolchok added the release notes: runtime Changes related to the core runtime which loads the program methods, initializes delegates, and runs label Jan 17, 2025
manuelcandales
manuelcandales requested changes Jan 22, 2025
View reviewed changes
extension/runner_util/inputs_portable.cpp Outdated

switch (tensor.scalar_type()) {
ET_FORALL_REAL_TYPES_AND(Bool, FILL_CASE)
ET_FORALL_REALHBF16_TYPES(FILL_CASE)
Copy link
Contributor

@manuelcandales manuelcandales Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing boolean. Use ET_FORALL_REALHBBF16_TYPES

Copy link
Contributor Author

@swolchok swolchok Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@swolchok
Update
92649e7 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jan 22, 2025
@swolchok
Support Half/BFloat16 in runner_util/inputs_portable
53b72d7 
Partial fix for #7748.

ghstack-source-id: 5a160a2
ghstack-comment-id: 2599375147
Pull Request resolved: #7750
@swolchok
Update
7c6ecd6 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jan 22, 2025
@swolchok
Support Half/BFloat16 in runner_util/inputs_portable
72cec05 
Partial fix for #7748.

ghstack-source-id: ee71b44
ghstack-comment-id: 2599375147
Pull Request resolved: #7750
@swolchok swolchok merged commit 091bc4a into main Jan 23, 2025
44 of 45 checks passed
@swolchok swolchok deleted the gh/swolchok/144/head branch January 23, 2025 17:58
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
@swolchok @YIWENX14
Support Half/BFloat16 in runner_util/inputs_portable (#7750)
724aa1f 
Partial fix for #7748.
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
@swolchok
Support Half/BFloat16 in runner_util/inputs_portable (pytorch#7750)
cb36e43 
Partial fix for pytorch#7748.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuelcandales manuelcandales manuelcandales approved these changes

@dbort dbort Awaiting requested review from dbort

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: runtime Changes related to the core runtime which loads the program methods, initializes delegates, and runs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok @manuelcandales @facebook-github-bot