Skip to content

Support Half/BFloat16 in runner_util/inputs_portable #7750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Support Half/BFloat16 in runner_util/inputs_portable #7750

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df3ce0d
Update
swolchok Jan 17, 2025
92649e7
Update
swolchok Jan 22, 2025
7c6ecd6
Update
swolchok Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions extension/runner_util/inputs_portable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ Error fill_ones(torch::executor::Tensor tensor) {
std::fill( \
tensor.mutable_data_ptr<T>(), \
tensor.mutable_data_ptr<T>() + tensor.numel(), \
1); \
T(1)); \
break;

switch (tensor.scalar_type()) {
ET_FORALL_REAL_TYPES_AND(Bool, FILL_CASE)
ET_FORALL_REALHBF16_TYPES(FILL_CASE)
Copy link
Contributor

@manuelcandales manuelcandales Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing boolean. Use ET_FORALL_REALHBBF16_TYPES

Copy link
Contributor Author

@swolchok swolchok Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

default:
ET_LOG(Error, "Unsupported scalar type %d", (int)tensor.scalar_type());
return Error::InvalidArgument;
Expand Down
Loading