Skip to content

unbreak op_fill in release builds with -DNDEBUG #7873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swolchok merged 3 commits into from
Jan 23, 2025
Merged

unbreak op_fill in release builds with -DNDEBUG #7873

swolchok merged 3 commits into from
Jan 23, 2025

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Jan 23, 2025 •
edited
Loading

No description provided.

@swolchok
Update
c7a950f 
[ghstack-poisoned]
@swolchok
Update
34f3725 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jan 23, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7873

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@swolchok swolchok mentioned this pull request Jan 23, 2025
Merged
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 23, 2025
swolchok added a commit that referenced this pull request Jan 23, 2025
@swolchok
unbreak op_fill in release builds with -DNDEBUG
1375868 
ghstack-source-id: dd690e1
ghstack-comment-id: 2608736132
Pull Request resolved: #7873
@swolchok
Copy link
Contributor Author

swolchok commented Jan 23, 2025

#7809 is probably the root cause here.

Base automatically changed from gh/swolchok/187/head to main January 23, 2025 03:24
@swolchok
Copy link
Contributor Author

swolchok commented Jan 23, 2025

unittest / linux is working, landing to unbreak without waiting for the last few slower builds

@swolchok
Update
2964676 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jan 23, 2025
@swolchok
unbreak op_fill in release builds with -DNDEBUG
eb369b9 
ghstack-source-id: 9b7b2f7
ghstack-comment-id: 2608736132
Pull Request resolved: #7873
@swolchok swolchok merged commit bd86777 into main Jan 23, 2025
5 of 7 checks passed
@swolchok swolchok deleted the gh/swolchok/188/head branch January 23, 2025 03:26
@github-actions
Copy link

github-actions bot commented Jan 23, 2025

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
@swolchok @YIWENX14
unbreak op_fill in release builds with -DNDEBUG (#7873)
8895d2d
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
@swolchok
unbreak op_fill in release builds with -DNDEBUG (pytorch#7873)
14a2226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jack-Khuu Jack-Khuu Jack-Khuu approved these changes

@dbort dbort Awaiting requested review from dbort

@GregoryComer GregoryComer Awaiting requested review from GregoryComer

@manuelcandales manuelcandales Awaiting requested review from manuelcandales manuelcandales is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok @Jack-Khuu @facebook-github-bot