Skip to content

unbreak op_fill in release builds with -DNDEBUG #7873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swolchok merged 3 commits into from
Jan 23, 2025
Merged

unbreak op_fill in release builds with -DNDEBUG #7873

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7a950f
Update
swolchok Jan 23, 2025
34f3725
Update
swolchok Jan 23, 2025
2964676
Update
swolchok Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions kernels/portable/cpu/op_fill.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,7 @@ Tensor& fill_tensor_out(
CTYPE_A b_casted;
ET_SWITCH_REALHBBF16_TYPES(b_type, ctx, "fill.Tensor_out", CTYPE_B, [&] {
CTYPE_B b_val;
ET_DCHECK_MSG(
extract_scalar_tensor(b, &b_val), "extract_scalar_tensor failed!");
ET_EXTRACT_SCALAR_TENSOR(b, b_val);
b_casted = static_cast<CTYPE_A>(b_val);
});

Expand Down
2 changes: 1 addition & 1 deletion test/run_oss_cpp_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ report_coverage() {

run_ctest() {
pushd cmake-out/
ctest
ctest --output-on-failure
popd
}

Expand Down
Loading