[devtool] make datasink as a sepreate directory #8514
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this diff make data_sink_base and its childrens as a seperate directory for better structure. Differential Revision: [D69732404](https://our.internmc.facebook.com/intern/diff/D69732404/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8514
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f519ba6 with merge base 745be4e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69732404 |
Gasoonjia
added a commit
that referenced
this pull request
Feb 17, 2025
this diff make data_sink_base and its childrens as a seperate directory for better structure. Differential Revision: [D69732404](https://our.internmc.facebook.com/intern/diff/D69732404/) ghstack-source-id: 266774369 Pull Request resolved: #8514
this diff make data_sink_base and its childrens as a seperate directory for better structure. Differential Revision: [D69732404](https://our.internmc.facebook.com/intern/diff/D69732404/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D69732404 |
Gasoonjia
added a commit
that referenced
this pull request
Feb 17, 2025
Pull Request resolved: #8514 this diff make data_sink_base and its childrens as a seperate directory for better structure. Differential Revision: [D69732404](https://our.internmc.facebook.com/intern/diff/D69732404/) ghstack-source-id: 266868291
tarun292
approved these changes
Feb 18, 2025
this diff make data_sink_base and its childrens as a seperate directory for better structure. Differential Revision: [D69732404](https://our.internmc.facebook.com/intern/diff/D69732404/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D69732404 |
this diff make data_sink_base and its childrens as a seperate directory for better structure. Differential Revision: [D69732404](https://our.internmc.facebook.com/intern/diff/D69732404/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D69732404 |
Gasoonjia
added a commit
that referenced
this pull request
Feb 25, 2025
Pull Request resolved: #8514 this diff make data_sink_base and its childrens as a seperate directory for better structure. ghstack-source-id: 268177711 Differential Revision: [D69732404](https://our.internmc.facebook.com/intern/diff/D69732404/)
this diff make data_sink_base and its childrens as a seperate directory for better structure. Differential Revision: [D69732404](https://our.internmc.facebook.com/intern/diff/D69732404/) [ghstack-poisoned]
Gasoonjia
added a commit
that referenced
this pull request
Feb 25, 2025
Pull Request resolved: #8514 this diff make data_sink_base and its childrens as a seperate directory for better structure. ghstack-source-id: 268177987 Differential Revision: [D69732404](https://our.internmc.facebook.com/intern/diff/D69732404/)
|
This pull request was exported from Phabricator. Differential Revision: D69732404 |
this diff make data_sink_base and its childrens as a seperate directory for better structure. Differential Revision: [D69732404](https://our.internmc.facebook.com/intern/diff/D69732404/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D69732404 |
Gasoonjia
added a commit
that referenced
this pull request
Feb 25, 2025
Pull Request resolved: #8514 this diff make data_sink_base and its childrens as a seperate directory for better structure. ghstack-source-id: 268186751 Differential Revision: [D69732404](https://our.internmc.facebook.com/intern/diff/D69732404/)
|
@pytorchbot label "topic: not user facing" |
Gasoonjia
had a problem deploying
to
cherry-pick-bot
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
this diff make data_sink_base and its childrens as a seperate directory for better structure.
Differential Revision: D69732404