Skip to content

Re-enable optimized gelu test in CMake #8597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2025
Merged

Re-enable optimized gelu test in CMake #8597

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d762040
Re-enable optimized gelu test in CMake
Feb 20, 2025
cb7292d
Update on "Re-enable optimized gelu test in CMake"
Feb 20, 2025
5168a78
Update on "Re-enable optimized gelu test in CMake"
swolchok Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions kernels/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ foreach(kernel ${_kernels})
cp
"${CMAKE_CURRENT_BINARY_DIR}/../../kernels/${kernel}/${kernel}_ops_lib/*.h"
"${CMAKE_CURRENT_BINARY_DIR}/include/${kernel}/executorch/kernels/${kernel}/"
DEPENDS "${kernel}_ops_lib"
DEPENDS "${kernel}_ops_lib"
)
endforeach()

Expand Down Expand Up @@ -278,10 +278,8 @@ set(_optimized_kernels_test_sources
${CMAKE_CURRENT_BINARY_DIR}/include/portable/executorch/kernels/test/supported_features.cpp
)

# We don't have sleef on OSS so we don't have gelu and log_softmax
list(REMOVE_ITEM _optimized_kernels_test_sources "op_gelu_test.cpp"
"op_log_softmax_test.cpp"
)
# We don't have sleef on OSS so we don't have log_softmax
list(REMOVE_ITEM _optimized_kernels_test_sources "op_log_softmax_test.cpp")

et_cxx_test(
optimized_kernels_test
Expand Down
Loading