Skip to content

[ET-VK] Renaming slice_channel and slice_batch_height_width files to reflect change in its utility. #9137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2025
Merged

[ET-VK] Renaming slice_channel and slice_batch_height_width files to reflect change in its utility. #9137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
baa095a
[ET-VK] Renaming slice_channel and slice_batch_height_width files to …
trivedivivek Mar 11, 2025
cd82fe0
Update on "[ET-VK] Renaming slice_channel and slice_batch_height_widt…
trivedivivek Mar 11, 2025
a68303c
Update on "[ET-VK] Renaming slice_channel and slice_batch_height_widt…
trivedivivek Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...runtime/graph/ops/glsl/slice_channel.glsl → ...time/graph/ops/glsl/slice_packed_dim.glsl
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...runtime/graph/ops/glsl/slice_channel.yaml → ...time/graph/ops/glsl/slice_packed_dim.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
slice_channel:
slice_packed_dim:
parameter_names_with_default_values:
DTYPE: float
NDIM: 3
Expand All @@ -8,4 +8,4 @@ slice_channel:
- VALUE: half
- VALUE: float
shader_variants:
- NAME: slice_channel
- NAME: slice_packed_dim
0 ...ph/ops/glsl/slice_batch_height_width.glsl → ...me/graph/ops/glsl/slice_unpacked_dim.glsl
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...ph/ops/glsl/slice_batch_height_width.yaml → ...me/graph/ops/glsl/slice_unpacked_dim.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
slice_batch_height_width:
slice_unpacked_dim:
parameter_names_with_default_values:
DTYPE: float
NDIM: 3
Expand All @@ -7,4 +7,4 @@ slice_batch_height_width:
- VALUE: half
- VALUE: float
shader_variants:
- NAME: slice_batch_height_width
- NAME: slice_unpacked_dim
4 changes: 2 additions & 2 deletions backends/vulkan/runtime/graph/ops/impl/Slice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ void add_slice_tensor_copy_node(
// if slice dim is the same as the packed dim, we can use the channel slice
if (dim_index == packed_dim_idx) {
// slice by channel
std::string kernel_name = "slice_channel";
std::string kernel_name = "slice_packed_dim";
kernel_name.reserve(kShaderNameReserve);
add_dtype_suffix(kernel_name, *t_out);

Expand Down Expand Up @@ -119,7 +119,7 @@ void add_slice_tensor_copy_node(
in_channel_stride = utils::div_up_4(in_channel_stride);
}

std::string kernel_name = "slice_batch_height_width";
std::string kernel_name = "slice_unpacked_dim";
kernel_name.reserve(kShaderNameReserve);
add_dtype_suffix(kernel_name, *t_out);

Expand Down
Loading