[ET-VK] Renaming slice_channel and slice_batch_height_width files to reflect change in its utility. #9137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reflect change in its utility. This diff renames files `slice_batch_height_width.y*` to `slice_unpacked_dim.*` and `slice_channel.*` to `slice_packed_dim.*` to reflect the change in their utility after enabling all dim packing for slice op. Differential Revision: [D70919994](https://our.internmc.facebook.com/intern/diff/D70919994/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9137
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a68303c with merge base e763a83 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Mar 11, 2025
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70919994 |
yipjustin
approved these changes
Mar 11, 2025
…h files to reflect change in its utility." This diff renames files `slice_batch_height_width.y*` to `slice_unpacked_dim.*` and `slice_channel.*` to `slice_packed_dim.*` to reflect the change in their utility after enabling all dim packing for slice op. Differential Revision: [D70919994](https://our.internmc.facebook.com/intern/diff/D70919994/) [ghstack-poisoned]
…h files to reflect change in its utility." This diff renames files `slice_batch_height_width.y*` to `slice_unpacked_dim.*` and `slice_channel.*` to `slice_packed_dim.*` to reflect the change in their utility after enabling all dim packing for slice op. Differential Revision: [D70919994](https://our.internmc.facebook.com/intern/diff/D70919994/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D70919994 |
facebook-github-bot
merged commit ab19982
into
gh/trivedivivek/60/base
52 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
SS-JIA
pushed a commit
that referenced
this pull request
Mar 11, 2025
…reflect change in its utility. (#9170) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #9137 by @trivedivivek ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/60/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/60/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/trivedivivek/59/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/trivedivivek/60/orig @diff-train-skip-merge --------- Co-authored-by: Vivek Trivedi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff renames files
slice_batch_height_width.y*toslice_unpacked_dim.*andslice_channel.*toslice_packed_dim.*to reflect the change in their utility after enabling all dim packing for slice op.Differential Revision: D70919994