Add support for ellipsis (...) indexing in Helion #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
This was referenced Aug 6, 2025
yf225
added a commit
that referenced
this pull request
Aug 6, 2025
stack-info: PR: #437, branch: yf225/stack/53
jansel
requested changes
Aug 6, 2025
Comment on lines
+453
to
+458
| def _calculate_ellipsis_dims( | ||
| index: list[object], current_index: int, total_dims: int | ||
| ) -> int: | ||
| """Calculate how many dimensions an ellipsis should expand to.""" | ||
| remaining_indices = len(index) - current_index - 1 | ||
| return total_dims - current_index - remaining_indices |
There was a problem hiding this comment.
I don't think this is right when combined with None (which will increment i in the caller but not consume an input dimension.
Comment on lines
+230
to
+232
| if k is Ellipsis: | ||
| # Ellipsis is not supported in tensor descriptor mode | ||
| return False |
There was a problem hiding this comment.
Is this hard to support? Maybe we we pre-expand the indexing string the existing code could work unmodified.
stack-info: PR: #437, branch: yf225/stack/53
|
After thinking more about it: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Add support for ellipsis (...) indexing in Helion