Fix tensor value assignment and partial indexing in Helion #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 6, 2025
meta-cla
bot
added
the
CLA Signed
jansel
requested changes
Aug 6, 2025
There was a problem hiding this comment.
Does this work with block_ptr/tensor descriptor? Add a test for this.
For stuff like this (and .../negative) maybe we should have a pre-processing pass the normalizes the index. That way we can handle them in one place rather than seperately for every type of indexing.
stack-info: PR: #439, branch: yf225/stack/55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Fix tensor value assignment and partial indexing in Helion