[generate_ast] providing AST args, and fall back to api._codegen
when output is a tuple
#481
+19
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two main points:
._codegen
TileIndexType
, correctly fallback to usingapi._codegen
Side note, I’m not entirely sure how to handle default AST arguments. For now, I’m just using
ast_params.apply_defaults()
, but I’m unsure if that’s the best way.