Skip to content

[generate_ast] providing AST args, and fall back to api._codegen when output is a tuple #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions helion/_compiler/generate_ast.py
Original file line number Diff line number Diff line change
Expand Up @@ -289,42 +289,51 @@ def visit_Call(self, node: ast.Call) -> ast.AST:
block_info.from_config(self.device_function.config)
)
)
elif isinstance(type_info, SequenceType):
elif (
isinstance(type_info, SequenceType)
and all(isinstance(x, TileIndexType) for x in type_info.unpack())
):
values = type_info.unpack()
if all(isinstance(x, TileIndexType) for x in values):
block_infos = [env.block_sizes[x.block_id] for x in values] # pyright: ignore[reportAttributeAccessIssue]
return expr_from_string(
self.host_function.literal_expr(
[
x.from_config(self.device_function.config)
for x in block_infos
]
)
block_infos = [env.block_sizes[x.block_id] for x in values] # pyright: ignore[reportAttributeAccessIssue]
return expr_from_string(
self.host_function.literal_expr(
[
x.from_config(self.device_function.config)
for x in block_infos
]
)
)
elif (
isinstance(fn_type_info := func_node._type_info, CallableType)
and is_api_func(api := fn_type_info.value)
and api._codegen is not None
):
ast_args = []
ast_kwargs = {}
proxy_args = []
proxy_kwargs = {}
for arg in node.args:
assert not isinstance(arg, ast.Starred)
assert isinstance(arg, ExtendedAST)
assert arg._type_info is not None
ast_args.append(arg)
proxy_args.append(arg._type_info.proxy())
for kwarg in node.keywords:
assert kwarg.arg is not None
assert isinstance(kwarg.value, ExtendedAST)
assert kwarg.value._type_info is not None
ast_kwargs[kwarg.arg] = kwarg.value
proxy_kwargs[kwarg.arg] = kwarg.value._type_info.proxy()
ast_params = api._signature.bind(*ast_args, **ast_kwargs)
proxy_params = api._signature.bind(*proxy_args, **proxy_kwargs)
ast_params.apply_defaults()
proxy_params.apply_defaults()
return api._codegen( # pyright: ignore[reportReturnType]
CodegenState(
self,
None,
proxy_args=[*proxy_params.arguments.values()],
ast_args=[*ast_params.arguments.values()],
)
)
return self.generic_visit(node)
Expand Down
Loading