Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@swolchok
Copy link
Contributor

q.dtype is always torch.float at this point. Clearly meant to use the input dtype.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Sep 24, 2024

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 24, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1193

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 6a1ff58 with merge base 6d2ef4a (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Sep 24, 2024
…at16

q.dtype is always torch.float at this point. Clearly meant to use the input dtype.

ghstack-source-id: 2c002e3
ghstack-comment-id: 2371952019
Pull Request resolved: #1193
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 24, 2024
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Sep 24, 2024
…at16

q.dtype is always torch.float at this point. Clearly meant to use the input dtype.

ghstack-source-id: 0fc583e
ghstack-comment-id: 2371952019
Pull Request resolved: #1193
Base automatically changed from gh/swolchok/13/head to main September 24, 2024 19:19
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Sep 24, 2024
…at16

q.dtype is always torch.float at this point. Clearly meant to use the input dtype.

ghstack-source-id: 0fc583e
ghstack-comment-id: 2371952019
Pull Request resolved: #1193
[ghstack-poisoned]
@swolchok swolchok merged commit 3aba730 into main Sep 24, 2024
49 of 51 checks passed
@swolchok swolchok deleted the gh/swolchok/14/head branch September 24, 2024 21:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants