This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Bump torchtune pin to a 9-24 commit; Update Flamingo Definition #1195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1195
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5ce5e9d with merge base 6d2ef4a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Jack-Khuu
approved these changes
Sep 24, 2024
Jack-Khuu
approved these changes
Sep 25, 2024
Comment on lines
+92
to
+94
| set -x | ||
| $PIP_EXECUTABLE install git+https://github.com/pytorch/torchtune.git@18efc81dda1c537bb7c25058ff059b4623ccff58 | ||
| ) |
There was a problem hiding this comment.
This works on Mac now right?
There was a problem hiding this comment.
yeah and mac tests passed
torchchat/generate.py
Outdated
| or self.model.config.model_type == ModelType.Flamingo | ||
| ): | ||
| model.setup_caches(max_batch_size=1, dtype=self.dtype) | ||
| model.setup_caches(batch_size=1, dtype=self.dtype, encoder_max_seq_len=6404, decoder_max_seq_len=max_seq_length-1) |
There was a problem hiding this comment.
it is the size that can hold single image input while one-gpu affordable.
There was a problem hiding this comment.
I will leave a comment
Jack-Khuu
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Torchtune updates flamingo model definition, as well as its inference. This PR aims to update torchchat pipeline to sync with torchtune