Skip to content

Conversation

@djhoese
Copy link
Member

@djhoese djhoese commented Feb 21, 2025

Replacement for #3068. In that PR I started updating sphinx usage to 8.2.0 and then realized there is a memory leak in 8.2.0 that causes RTD builds to fail. In this PR I keep the CI warning fix, but limit sphinx so 8.2.0 isn't used.

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@djhoese djhoese added documentation cleanup Code cleanup but otherwise no change in functionality labels Feb 21, 2025
@djhoese djhoese requested a review from mraspaud as a code owner February 21, 2025 17:10
@codecov
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (17cf0ce) to head (aecf736).
Report is 407 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3071      +/-   ##
==========================================
- Coverage   96.14%   96.11%   -0.04%     
==========================================
  Files         383      383              
  Lines       55785    55685     -100     
==========================================
- Hits        53636    53523     -113     
- Misses       2149     2162      +13     
Flag Coverage Δ
behaviourtests 3.88% <ø> (+<0.01%) ⬆️
unittests 96.21% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djhoese
Copy link
Member Author

djhoese commented Feb 24, 2025

I'm going to close this. It shouldn't be needed now that sphinx was patched. #3068 should be the PR to be merged.

@djhoese djhoese closed this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code cleanup but otherwise no change in functionality documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant