fix: remove onnxruntime cap as not needed anymore #517
Conversation
📝 WalkthroughWalkthroughThe changes update the "fastembed" package version from 0.6.1 to 0.7.0 in the project configuration file. The dependency specification for the "onnxruntime" package is simplified by removing platform-specific markers and version constraints, now depending only on Python version ranges: for Python 3.13 and above, "onnxruntime" must be greater than 1.20.0; for Python versions between 3.10 and 3.13, the required versions are at least 1.17.0 but not 1.20.0. Additionally, explicit type annotations and type ignore comments are added in the Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (15)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
pyproject.toml (1)
23-24: Verify onnxruntime dependency constraints
The platform-specific markers have been removed, which simplifies the spec. However, there are still upper-bound constraints (<1.20.0for<3.10and!=1.20.0for>=3.10,<3.13). Since onnxruntime wheels are now published for all supported platforms, confirm whether these caps are still necessary. If not, you can collapse to a single>=1.17.0entry and reorder the blocks in ascending Python range for readability.Proposed diff:
[tool.poetry.dependencies] onnxruntime = [ - { version = ">=1.17.0,<1.20.0", python = "<3.10" }, - { version = ">1.20.0", python = ">=3.13" }, - { version = ">=1.17.0,!=1.20.0", python = ">=3.10,<3.13" }, + { version = ">=1.17.0", python = "<3.10" }, + { version = ">=1.17.0", python = ">=3.10,<3.13" }, + { version = ">=1.17.0", python = ">=3.13" }, ]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (15)
- GitHub Check: Python 3.10.x on macos-latest test
- GitHub Check: Python 3.13.x on macos-latest test
- GitHub Check: Python 3.11.x on windows-latest test
- GitHub Check: Python 3.12.x on macos-latest test
- GitHub Check: Python 3.13.x on windows-latest test
- GitHub Check: Python 3.12.x on ubuntu-latest test
- GitHub Check: Python 3.12.x on windows-latest test
- GitHub Check: Python 3.13.x on ubuntu-latest test
- GitHub Check: Python 3.9.x on windows-latest test
- GitHub Check: Python 3.11.x on ubuntu-latest test
- GitHub Check: Python 3.10.x on windows-latest test
- GitHub Check: Python 3.10.x on ubuntu-latest test
- GitHub Check: Python 3.11.x on macos-latest test
- GitHub Check: Python 3.9.x on macos-latest test
- GitHub Check: Python 3.9.x on ubuntu-latest test
| [tool.poetry] | ||
| name = "fastembed" | ||
| version = "0.6.1" | ||
| version = "0.7.0" |
There was a problem hiding this comment.
💡 Verification agent
❓ Verification inconclusive
Bump package version to 0.7.0
This correctly updates the package version. Please ensure the lock file has been regenerated (poetry lock) and committed, and that any CHANGELOG entries or documentation referencing the old version have been updated as well.
To verify no leftover references to 0.6.1, run:
🏁 Script executed:
#!/bin/bash
# Search the repo for any stray mentions of the old version
rg "0\.6\.1"Length of output: 14
Bump package version to 0.7.0 — no stray references remaining
All occurrences of 0.6.1 have been removed. Please complete the remaining version bump tasks before merging:
- Run
poetry lockand commit the updatedpoetry.lock. - Update any CHANGELOG entries and documentation to reference v0.7.0.
onnx wheels for onnxruntime have been published