Skip to content

fix: remove onnxruntime cap as not needed anymore #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joein merged 2 commits into from
May 13, 2025
Merged

fix: remove onnxruntime cap as not needed anymore #517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6882d2
fix: remove onnxruntime cap as not needed anymore
joein May 13, 2025
19426cc
fix: fix mypy complaints in python3.13
joein May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions fastembed/sparse/minicoil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,13 +295,13 @@ def _post_process_onnx_output(
)

# Size of counts: (unique_words)
words_ids = ids_mapping[:, 0].tolist()
words_ids: list[int] = ids_mapping[:, 0].tolist() # type: ignore[assignment]

sentence_result: dict[str, WordEmbedding] = {}

words = [self.vocab_resolver.lookup_word(word_id) for word_id in words_ids]

for word, word_id, emb in zip(words, words_ids, minicoil_embeddings.tolist()):
for word, word_id, emb in zip(words, words_ids, minicoil_embeddings.tolist()): # type: ignore[arg-type]
if word_id == 0:
continue

Expand All @@ -310,7 +310,7 @@ def _post_process_onnx_output(
forms=forms[word],
count=int(counts[word_id]),
word_id=int(word_id),
embedding=emb,
embedding=emb, # type: ignore[arg-type]
)

for oov_word, count in oov.items():
Expand Down
Loading