-
-
Notifications
You must be signed in to change notification settings - Fork 43.4k
Add the Cirrus40 keyboard #25887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add the Cirrus40 keyboard #25887
Conversation
5092227 to
fb44009
Compare
|
Thanks for the quick review, applied. |
|
By the way, why did you suggest removing LTO? Locally I set |
|
because, in general LTO is used primarily as a means for space savings. And short of using Quantum Painter and full on images, there is absolutely no shortage of space on RP2040's (1-16MB flash chips, and all). Aside from that, additional optimizations aren't really going to gain you a lot. And optimization is more likely to cause issues than be helpful here. |
|
@drashna What is the remaining process to land this PR? Do you have more comments? |
A 40% keyboard with focus on usable encoders. The PCB uses external pullups for encoder pins, hence the custom initialization logic. https://github.com/schuay/cirrus40
Applied requested changes. Co-authored-by: Joel Challis <[email protected]>
|
@zvecr thanks for the review, all requested changes applied. Please take a look again. |
A 40% keyboard with focus on usable encoders. The PCB uses external pullups for encoder pins, hence the custom initialization logic.
https://github.com/schuay/cirrus40
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist